22 Jun 2025 |
hexa | - The package "erusev/parsedown" is pointing to a commit-ref, this is bad practice and can cause unforeseen issues.
- require.erusev/parsedown : exact version constraints (1.7.x-dev#f7285e7b2c55039401e9d380741c2dc805edf980) should be avoided if the package follows semantic versioning
| 18:29:15 |
hexa | and the lints I'm getting look like shoulds, not musts | 18:29:34 |
hexa | it doesn't look like there is a knot to simply opt out of this check | 18:32:11 |
hexa | * and it doesn't look like there is a knot to simply opt out of this check | 18:32:13 |
hexa | * and it doesn't look like there is a knob to simply opt out of this check | 18:32:19 |
hexa | ok, apparently I can use mkComposerVendor instead and that is non-blocking | 18:43:06 |
Pol | hexa: Can you disable strict validation ? | 20:26:31 |
Pol | `composerStrictValidation = false; | 20:26:51 |
Pol | * `composerStrictValidation = false;` | 20:26:52 |
hexa | indeed that seems to work | 20:28:28 |
hexa | I overlooked the noisy shell script | 20:29:41 |
hexa |  Download image.png | 20:29:51 |
Pol | I had to do that because there are some package in PHP that does not pass this check | 20:29:59 |
Pol | (phpstan IIRC) | 20:30:00 |
Pol | It's fine | 20:30:22 |
Pol | It happen | 20:30:22 |
Pol | If you see some stuff that could be improved there, just let me know | 20:30:37 |
hexa |  Download image.png | 20:30:46 |
hexa | and yeah, if there is a var like that, document it in the php section please | 20:31:15 |
Pol | Totally. | 20:31:15 |
hexa | in fact make it a list of all relevant variables, like the composerNoDev one | 20:31:26 |
Pol | Are you willing to submit a PR for what you did there? I can submit the PR for the doc | 20:31:42 |
hexa | not currently, sorry | 20:33:18 |
hexa | I was mostly just mocking this on one case, but there are multiple, at least two 🙂 | 20:33:33 |
Pol | What's the other one? | 20:34:11 |
Pol | Going to do it now, I have a bit of time | 20:34:16 |
Pol | (seen both of them) | 20:51:48 |
Pol | https://github.com/NixOS/nixpkgs/pull/419094 | 21:00:55 |
Pol | I'll see the feedback tomorrow, not going to self merge this :D | 21:06:29 |
25 Jun 2025 |
| neobrain joined the room. | 09:19:17 |