| 2 May 2024 |
 @drupol:matrix.org | * In the following draft PR, I can now run extra composer commands before building the composer repository (vendor) ! | 20:31:15 |
|  @nick_kadutskyi:matrix.org set a profile picture. | 21:19:13 |
| 4 May 2024 |
| @drupol:matrix.org | https://github.com/NixOS/nixpkgs/pull/309112 | 21:08:05 |
| @drupol:matrix.org | https://github.com/NixOS/nixpkgs/pull/309132 | 22:17:49 |
| 5 May 2024 |
|  @genghiz:talk.go7box.xyz joined the room. | 07:55:57 |
| @drupol:matrix.org | catman: ping | 07:56:40 |
| @genghiz:talk.go7box.xyz | I'm here | 07:56:49 |
| @drupol:matrix.org | Setting the APCU Autoloader Prefix to the package name might introduce symbols that are not valid. | 07:57:06 |
| @drupol:matrix.org | (space, hyphens, etc etc) | 07:57:14 |
| @genghiz:talk.go7box.xyz | Right, so a base64 encode of the package name? | 07:57:26 |
| @genghiz:talk.go7box.xyz | I mean, it could be anything, I don't think the exact prefix matters, right? | 07:57:45 |
| @genghiz:talk.go7box.xyz | I sort of meant that the builder seems to have a fixed string | 07:57:53 |
| @drupol:matrix.org | I did this instead: https://github.com/NixOS/nixpkgs/blob/990a2161d9e5c72db6227e0d395762c1ec27b751/pkgs/build-support/php/hooks/composer-install-hook.sh#L31 | 07:57:54 |
| @genghiz:talk.go7box.xyz | Yeah, that's what I was confused by | 07:58:11 |
| @drupol:matrix.org | Until the patch is not in Composer, I must use that flag. | 07:58:25 |
| @drupol:matrix.org | Once it will be merged, that flag will be obsolete. | 07:58:38 |
| @genghiz:talk.go7box.xyz | Right. Till then why use a fixed flag? | 07:58:43 |
| @drupol:matrix.org | Because it's not merged in Composer yet. | 07:59:04 |
| @genghiz:talk.go7box.xyz | I get that. But ApcuAutoloaderPrefix can be set by the package itself, no? | 07:59:28 |
| @genghiz:talk.go7box.xyz | Why not have it hew as close to what upstream will eventually be? | 07:59:37 |
| @drupol:matrix.org | Can you tell me what you would change in there? I don't get your point... sorry :S | 08:00:21 |
| @genghiz:talk.go7box.xyz | I am assuming that the string ApcuAutoloaderPrefix is the literal prefix which will be set for each package | 08:00:54 |
| @genghiz:talk.go7box.xyz | I think that before your upstream changes are merged (and there is a very slight chance upstream will just say no), it might be a good idea to implement the md5 hash thing downstream itself | 08:01:33 |
| @genghiz:talk.go7box.xyz | That would ensure that every package will have a different prefix | 08:01:45 |
| @drupol:matrix.org | We don't care about packages having different prefix... since they are all isolated from each other, there is NO risk of collision. | 08:02:21 |
| @genghiz:talk.go7box.xyz | That's also true. | 08:02:35 |
| @drupol:matrix.org | That's a cool thing from Nix :) | 08:02:44 |
| @genghiz:talk.go7box.xyz | Hah | 08:02:49 |
| @genghiz:talk.go7box.xyz | True that | 08:02:51 |
| @drupol:matrix.org | (one of the true thing!) | 08:02:59 |
