| 25 Nov 2023 |
 Gaël Reyrol | Turns out that golang still do not include non go files when vendoring : https://github.com/golang/go/issues/26366 | 15:33:28 |
| Gaël Reyrol | * It is worth to mention that golang still do not include non go files when vendoring : https://github.com/golang/go/issues/26366 | 15:33:43 |
| Gaël Reyrol | I am not sure I want to try to compile it with musl, it will take ages 🤣 | 15:45:38 |
| Gaël Reyrol | Pol: the PR is ready to review :) | 15:52:50 |
 Pol | Il manque le mainProgram | 16:11:47 |
| Pol | Ah non sorry ! :) | 16:12:00 |
| Pol | c'est beau | 16:12:36 |
| Pol | I don't understand this part: https://github.com/NixOS/nixpkgs/pull/268665/files#diff-f50bfb682218622afd9adb8e68164f487edb707b2ae68e05ceb6504388b1f24cR75-R79 | 16:22:38 |
| Gaël Reyrol | This part allows to build a phpinfo page with Frankenphp as engine. Also if it fails, it means frankenphp is not properly working. | 16:42:53 |
| Gaël Reyrol | Try it: nix-build -A frankenphp.tests.phpinfo and open the result in your browser. | 16:43:18 |
| Gaël Reyrol | Pol: I reviewed my PR with some comments, I had some thoughts will taking a shower 😆 | 16:43:57 |
| Gaël Reyrol | * Pol: I reviewed my PR with some comments, I had some thoughts while taking a shower 😆 | 16:49:56 |
| Pol | About the buildInputs | 17:27:32 |
| Pol | Is it possible to do: | 17:27:40 |
| Pol | buildInputs = phpUnwrapped.buildInputs ++ [ pcre2 libargon2 libxml2 systemd ]; | 17:28:00 |
| Pol | * buildInputs = phpUnwrapped.buildInputs ++ [ pcre2 libargon2 libxml2 systemd ]; | 17:28:10 |
| Pol | Aaah you did it actually ! :D | 17:28:34 |
| Pol | Shower are always good :) | 17:29:55 |
| 27 Nov 2023 |
| Pol | Interesting discussion with Sebastian Bergmann regarding reproducibility: https://github.com/sebastianbergmann/phpunit/pull/5576#issuecomment-1827304401 | 07:54:33 |
| Pol | Especially this sentence:
And this is why: I do not think that PHPUnit should be installed using an operating system package manager.
| 07:54:50 |
| Pol | He doesn't know Nix! :) | 07:55:11 |
| Pol | I will prepare a reply later in the day. | 07:55:18 |
| Pol | This one as well:
So far, though, it had not occurred to me that putting composer.lock under version control might be relevant here.
| 07:55:50 |
| Pol | * Interesting discussion with Sebastian Bergmann (PHPUnit father) regarding reproducibility: https://github.com/sebastianbergmann/phpunit/pull/5576#issuecomment-1827304401 | 07:56:54 |
| Pol | If you have some hints on how I could reply on this, just let me know. | 07:57:13 |
 tgerbet | Just by reading your quotes I was thinking about the PHAR but after reading the GH issue it appears that Sebastian agrees with you 👍 | 22:47:36 |
| 29 Nov 2023 |
 Shyim | Is anyone working already on making frankenphp darwin compatible? | 08:39:10 |
| Pol | Not me, sorry. | 09:01:14 |
| Pol | Gaël Reyrol: Do you think you can replace rec with finalAttrs pattern? | 09:01:30 |
| Pol | (Context: https://github.com/NixOS/nixpkgs/pull/270861/files) | 09:01:38 |
