| 7 Sep 2023 |
 Jan Tojnar | the makefile is generated by phpize, IIRC | 20:28:05 |
 @drupol:matrix.org | yeah... is it an issue ? | 20:29:34 |
| @drupol:matrix.org | I wrote my findings here: https://github.com/fossar/nix-phps/pull/104#issuecomment-1710320818 | 20:30:48 |
| @drupol:matrix.org | Why there's no Makefile in the PHP distribution (in ext/tokenizer) | 20:31:21 |
| @drupol:matrix.org | That is also something I'd like to understand | 20:31:30 |
| @drupol:matrix.org | But since I never used those tools, it's complicated for me | 20:31:41 |
| Jan Tojnar | the lex error sounds like lex is missing some flag as well | 20:35:37 |
| @drupol:matrix.org | These are RE2C_FLAGS ? | 20:37:01 |
| @drupol:matrix.org | Have you seen this? https://github.com/php/php-src/blob/master/scripts/dev/genfiles | 20:45:00 |
| @drupol:matrix.org | Maybe we should use it ? | 20:45:04 |
| @drupol:matrix.org | GOT IT WORKING !!!! | 20:53:02 |
| @drupol:matrix.org | Just pushed the change | 20:54:05 |
| @drupol:matrix.org | Now going straigh to bed... | 20:55:38 |
| 8 Sep 2023 |
| @drupol:matrix.org | Lars Strojny: Now I will work on a PR to provide a flake.nix in the php/php-src source directly :) so we can have a CI that builds PHP at each commit ! | 05:01:49 |
| @drupol:matrix.org | And we are green ! https://github.com/fossar/nix-phps/pull/104 | 05:34:32 |
| @drupol:matrix.org | One year later :D | 05:34:35 |
| @drupol:matrix.org | php-master branch is building on Nix! https://github.com/fossar/nix-phps/pull/104 | 05:34:51 |
| @drupol:matrix.org | Someone to review this? https://github.com/NixOS/nixpkgs/pull/254001 | 10:17:31 |
| @drupol:matrix.org | Lars Strojny: I just made a flake.nix file for https://github.com/php/php-src that compile the master branch :) Works pretty fine !! Do you think it worth submitting a PR ? | 11:06:45 |
| @drupol:matrix.org | We could imagine also a default devShell that would provide all the tools needed for a PHP core developer :) | 11:07:23 |
| @drupol:matrix.org | We could imagine a Github action what would check if a commit is not breaking the builds ! :) | 11:14:36 |
| @drupol:matrix.org | Plenty of new possibilities !!! | 11:14:44 |
| @drupol:matrix.org | PR is green ^^ | 13:10:22 |
| @drupol:matrix.org | Feel free to add your voice to that PR, I really need it :) | 13:10:46 |
| @drupol:matrix.org | Thanks to that PR, I can now provide this: https://github.com/fossar/nix-phps/pull/104#issuecomment-1711706025 | 13:58:18 |
| @drupol:matrix.org | And a flake.nix for https://github.com/php/php-src ! :) | 13:58:32 |
| @drupol:matrix.org | Got it working on my machine :) | 13:58:44 |
| @drupol:matrix.org | => https://main.elk.zone/mathstodon.xyz/@Pol/111029255046941796 | 13:59:06 |
| 11 Sep 2023 |
| @drupol:matrix.org | I just created a PR to update the PHP mkderivation wrapper in Nix: https://github.com/NixOS/nixpkgs/pull/254556, reviews are welcome | 13:13:47 |
| 13 Sep 2023 |
|  w joined the room. | 01:29:07 |
