| 21 Jun 2023 |
@drupol:matrix.org | * Jan Tojnar: We came to a compromise in https://github.com/phpro/grumphp/issues/1095 ! The are going to include a composer.lock in the shim (phar distribution) package (https://github.com/phpro/grumphp-shim/pull/22). I was wondering what could be the best option to use it in the Grumphp derivation. What would be our best option ? (using srcs ?) | 20:49:08 |
Jan Tojnar | Pol: I would probably just fetchurl the lockfile, srcs never worked very well for me | 20:53:24 |
@drupol:matrix.org | so, composerLock = (fetchurl {...}) + "/phar.composer.lock"; | 20:54:31 |
@drupol:matrix.org | Or something like that ( i will manage) | 20:54:37 |
Jan Tojnar | yeah | 20:57:29 |
@drupol:matrix.org | Redacted or Malformed Event | 20:59:29 |
@drupol:matrix.org | Redacted or Malformed Event | 20:59:57 |
@drupol:matrix.org | Redacted or Malformed Event | 20:59:59 |
@drupol:matrix.org | Redacted or Malformed Event | 21:00:46 |
@drupol:matrix.org | Redacted or Malformed Event | 21:00:49 |
@drupol:matrix.org | * This is the definition of composerLock: | 21:00:53 |
@drupol:matrix.org | Redacted or Malformed Event | 21:01:11 |
@drupol:matrix.org | Redacted or Malformed Event | 21:01:34 |
@drupol:matrix.org | Redacted or Malformed Event | 21:11:19 |
@drupol:matrix.org | Job done: https://github.com/NixOS/nixpkgs/pull/225401/commits/4bde179df98d7d8d21cb53598e33f83c45e9f787 | 21:23:00 |
tgerbet | FYI on another topic, I'm currently bisecting the build issue of the PHP 8.3 fileinfo extension. Building php83Extensions.fileinfo works directly from the sources when pearSupport is set to false | 21:28:01 |
@drupol:matrix.org | Oh I wish I could do that with you | 21:30:09 |
@drupol:matrix.org | I'm curious to see how you handle that. | 21:30:24 |
tgerbet | https://gist.github.com/LeSuisse/5d9897f34d9c429854c8d8bfbf3835ef
/home/thomas/Workspace/PHP/php-src is my local clone of php-src that I'm bisecting | 21:35:59 |
@drupol:matrix.org | But this is not supposed to work | 21:38:19 |
tgerbet | Yup it crashes when withPear is true | 21:38:50 |
@drupol:matrix.org | We already tried with Jan Tojnar in: https://github.com/fossar/nix-phps/pull/104 | 21:38:58 |
@drupol:matrix.org | So it crashes because of Pear ? | 21:39:39 |
@drupol:matrix.org | How come this thing is still alive ?! | 21:39:50 |
@drupol:matrix.org | (I'll review your PR tomorrow) | 21:40:49 |
tgerbet | Well it's not happy about pear but maybe there are other issues when all the extensions are built, I did not test (yet) | 21:43:20 |
@drupol:matrix.org | mmh oki | 21:44:57 |
@drupol:matrix.org | I'll contine tomorrow | 21:46:46 |
@drupol:matrix.org | Btw, I just published a new PR for Guacamole: https://github.com/NixOS/nixpkgs/pull/237824 | 21:47:02 |
@drupol:matrix.org | Feel free to test/review ! | 21:47:08 |