Sender | Message | Time |
---|---|---|
28 Feb 2022 | ||
In reply to @etu:semi.socialOk good to know ! Is there a huge difference with the way I did it? | 09:08:25 | |
Thanks for merging the Phing PR ! The Grumphp PR has been fixed in the meantime. | 09:08:41 | |
And the one with the extensions update as well. | 09:08:52 | |
In reply to @drupol:matrix.orgNow all the builds become separate entities in the PR build result, if it's done in a single line it becomes a single result of several attributes so it's easier to overview. Also... less typing for you ;) | 09:10:43 | |
Okay okay will do that next time for sure. | 09:11:29 | |
PR to review: https://github.com/NixOS/nixpkgs/pull/159666 PR to review: https://github.com/NixOS/nixpkgs/pull/158098 | 09:12:16 | |
ramsey: Now that you're here, I can use you! Do you know anything about this issue? https://github.com/fossar/nix-phps/runs/5358453498?check_suite_focus=true Basically we have issues compiling PHP 7.2.34 on Mac OS. The rest is fine, it's just that PHP version which is failing. Of course, this is not a big deal because PHP 7.2 is not that used anymore, but still, if we could fix this, it would be great. Any clue? | 11:08:28 | |
In reply to @drupol:matrix.orgThe actual error message isn't shown there. It appears that the intl extension is having some problem with isfinite from libcxx-11.1.0-dev/include/c++/v1/math.h , but that's all I can tell right now | 22:14:10 | |
Good enough, I will check for a patch. I guess there is an issue about that because the issue is gone in 7.2+ | 22:19:27 | |
1 Mar 2022 | ||
PR ready for merging ! https://github.com/NixOS/nixpkgs/pull/158098 | 16:27:48 | |
And we got a new PHP contributor today : https://github.com/NixOS/nixpkgs/pull/162376 | 16:28:24 | |
2 Mar 2022 | ||
ramsey: I would like to push a change for PHP in Nix. Basically, I would like to replace the src URL in PHP extensions. I would like to change from using the URL provided by PECL to using the Git repository directly. Like that, we slowly move away from PECL and use Git exclusively and also, it can be picked up by the automatic updater (r-ryantm) bot to make sure that packages are always up-to-date. What do you think of that? Is PECL still used that much? Is it a good idea to slowly move away from it? | 08:15:41 | |
* ramsey: I would like to push a change for PHP in Nix. Basically, I would like to replace the src URL in PHP extensions. I would like to change from using the URL provided by PECL to using the Git repository directly. Like that, we slowly move away from PECL and use Git exclusively and also, it can be picked up by the automatic updater (r-ryantm) bot to make sure that packages are always up-to-date. What do you think of that? Is PECL still used that much? Is it a good idea to slowly move away from it? Are there any drawbacks by doing such thing? | 08:36:33 | |
3 Mar 2022 | ||
In reply to @drupol:matrix.orgPECL is still the primary way to distribute PHP extensions, and I’ve not heard anything about it going away anytime soon. There is a separate project called “pickle” that can take the place of PECL, though. I think whether the PHP project retires PECL depends on having someone come along who can propose a process for moving to something else and dedicate time and energy to making it happen. | 02:13:41 | |
https://github.com/FriendsOfPHP/pickle | 02:14:26 | |
But pecl relies on an external Git repo, right? It does not provide its own. | 06:17:45 | |
I'm trying to add a feature to generic.nix so we will be able to compile the development branch of PHP. I did this: https://github.com/NixOS/nixpkgs/compare/master...drupol:feat/let-php-compile-master-branch and it seems to work locally. It's building the branch master right now. But I'm wondering if this is the best way to do that. I see in the bottom of the file that there is a way to override some attributes, maybe I should do that. WDYT ? | 17:20:45 | |
Maybe I can do that with overrideAttrs but I'm having hard time finding how to use it. | 17:27:03 | |
I think I have it: | 17:30:28 | |
Download image.png | 17:30:30 | |
Nope. | 17:32:05 | |
4 Mar 2022 | ||
Right, I closed this issue https://github.com/NixOS/nixpkgs/pull/158098 as we were not aligned on how it should be done. | 15:05:41 | |
5 Mar 2022 | ||
Not sure why I’m not getting notifications from Element. Pol: I’m not sure what you mean by “pecl relies on an external Git repo.” I’m also don’t understand what that has to do with compiling the development branch of PHP. PHP has multiple development branches, btw. PHP-7.4 has 7.4.x-dev, PHP-8.0 has 8.0.x-dev, and PHP-8.1 has 8.1.x-dev. I think the master branch currently shows 8.2.x-dev. | 21:28:04 | |
ramsey: No worries, I closed the issue. Basically, all the PHP extensions in Nix are relying on PECL urls to downloads src. I wanted to change that and use GitHub exclusively so r-ryantm bot could pick up those projects and provide automatic PRs to update them when a tag is published. I closed the issue for 2 reasons. First reason is that I haven't got much support from Nix PHP maintainers, and secondly because it turns out that the bot already update those packages (maybe there was an update in the meantime). Regarding PHP development branches, this is another thing. I'm trying to build PHP from a dev branch and I will try those branches as well. I'm new to Nix (10 month), so there are things that I do not fully understand yet. | 21:45:08 | |
8 Mar 2022 | ||
16:11:02 | ||
16:11:56 | ||
10 Mar 2022 | ||
The majority of extensions are upstream extensions and built from the same source as the php distribution though :) | 07:11:57 | |
12 Mar 2022 | ||
In reply to @drupol:matrix.orgI'm newer to Nix (< 1 month), so you know a lot more about it than I do. 😉 | 20:00:13 | |
It's fine :D we're both newcomers! | 20:00:29 | |
If you need anything, just ask, I'll try to help as best as I can. | 20:00:41 |