16 Jun 2025 |
piotrkwiecinski | Hi all I'm not sure if you saw https://github.com/NixOS/nixpkgs/issues/416911 | 19:27:56 |
17 Jun 2025 |
Pol | Saw it | 08:57:32 |
Pol | I don't have much time for PHP stuff for the moment sadly... | 08:57:47 |
Pol | I would wait a bit for some feedback from jtojnar and the rest | 08:57:59 |
18 Jun 2025 |
Genghiz | If anyone has time could they review this? It's been in the pipes for a while now... https://github.com/NixOS/nixpkgs/pull/389071 | 06:31:33 |
Genghiz | I made the changes suggested in the comments. | 06:31:49 |
22 Jun 2025 |
hexa |  Download image.png | 18:27:45 |
hexa | why was this check made quiet? | 18:28:13 |
hexa | saying the check failed but not saying why is not helpful | 18:28:22 |
hexa | * saying the check failed but hiding why is not helpful | 18:28:28 |
hexa | - The package "erusev/parsedown" is pointing to a commit-ref, this is bad practice and can cause unforeseen issues.
- require.erusev/parsedown : exact version constraints (1.7.x-dev#f7285e7b2c55039401e9d380741c2dc805edf980) should be avoided if the package follows semantic versioning
| 18:29:15 |
hexa | and the lints I'm getting look like shoulds, not musts | 18:29:34 |
hexa | it doesn't look like there is a knot to simply opt out of this check | 18:32:11 |
hexa | * and it doesn't look like there is a knot to simply opt out of this check | 18:32:13 |
hexa | * and it doesn't look like there is a knob to simply opt out of this check | 18:32:19 |
hexa | ok, apparently I can use mkComposerVendor instead and that is non-blocking | 18:43:06 |
Pol | hexa: Can you disable strict validation ? | 20:26:31 |
Pol | `composerStrictValidation = false; | 20:26:51 |
Pol | * `composerStrictValidation = false;` | 20:26:52 |
hexa | indeed that seems to work | 20:28:28 |
hexa | I overlooked the noisy shell script | 20:29:41 |
hexa |  Download image.png | 20:29:51 |
Pol | I had to do that because there are some package in PHP that does not pass this check | 20:29:59 |
Pol | (phpstan IIRC) | 20:30:00 |
Pol | It's fine | 20:30:22 |
Pol | It happen | 20:30:22 |
Pol | If you see some stuff that could be improved there, just let me know | 20:30:37 |
hexa |  Download image.png | 20:30:46 |
hexa | and yeah, if there is a var like that, document it in the php section please | 20:31:15 |
Pol | Totally. | 20:31:15 |