| 20 Jan 2025 |
 Pol | No | 12:25:11 |
| Pol | Don't think so | 12:25:15 |
 piotrkwiecinski | I'll check a couple packages after work | 12:25:54 |
| Pol | excellent, thanks | 12:26:29 |
| Pol | Regarding the Drupal stuff up there | 12:26:35 |
| Pol | Things could definitely be improved in the builder | 12:26:49 |
| piotrkwiecinski | maybe something isn't passed or copied correctly | 12:27:51 |
| Pol | yep | 12:28:14 |
| piotrkwiecinski | or maybe an order of commands as copy should be done after composer install is done to have all dirs | 12:28:42 |
| Pol | Composer disable the plugins IIRC | 12:29:03 |
| Pol | That's probably the issue | 12:29:08 |
| piotrkwiecinski | it depends on the config | 12:29:20 |
| piotrkwiecinski | if you have allow plugins in composer.json they're not blocked | 12:29:36 |
| piotrkwiecinski | assuming we don't send --no-plugins explicitly | 12:29:56 |
| Pol | we do IIRC | 12:30:44 |
| piotrkwiecinski | we have it as a flag and reproducer sets it to false so in theory --no-plugins shouldn't be added but it needs confirmation if it actually works :) | 12:32:35 |
| piotrkwiecinski | https://getcomposer.org/doc/06-config.md#allow-plugins
Defaults to {} which does not allow any plugins to be loaded.
As of Composer 2.2.0, the allow-plugins option adds a layer of security allowing you to restrict which Composer plugins are able to execute code during a Composer run.
When a new plugin is first activated, which is not yet listed in the config option, Composer will print a warning. If you run Composer interactively it will prompt you to decide if you want to execute the plugin or not.
Use this setting to allow only packages you trust to execute code. Set it to an object with package name patterns as keys. The values are true to allow and false to disallow while suppressing further warnings and prompts.
| 12:36:10 |
| piotrkwiecinski | So if you have the allow-plugins in composer.json with "true"s it won't disable these plugins | 12:36:58 |
| Pol | This is what I meant: https://github.com/NixOS/nixpkgs/blob/f5b5e4d69cb858b79bfbc300980b13b4218d5b01/pkgs/build-support/php/builders/v2/hooks/composer-vendor-hook.sh#L34 | 12:50:07 |
| piotrkwiecinski | Yeah but setting:
composerNoPlugins = false;
composerNoScripts = false; | 12:52:17 |
| piotrkwiecinski | should prevent it right? | 12:52:22 |
| Pol | Technically yeah | 12:53:13 |
| Pol | But did they use it? | 12:53:20 |
| piotrkwiecinski | Yes | 12:53:25 |
| Pol | ah. | 12:53:42 |
| Pol | On another topic | 12:57:12 |
| Pol | ❯ nix build .#phpdocumentor -L --rebuild
phpdocumentor> Running phase: unpackPhase
phpdocumentor> unpacking source archive /nix/store/30ryfv45bmdj5nc3xbqfdrgb41wgdvr7-source
phpdocumentor> source root is source
phpdocumentor> Running phase: patchPhase
phpdocumentor> Running phase: updateAutotoolsGnuConfigScriptsPhase
phpdocumentor> Running phase: configurePhase
phpdocumentor> Executing composerInstallConfigureHook
phpdocumentor> Setting COMPOSER_ROOT_VERSION to 3.6.0
phpdocumentor> Finished composerInstallConfigureHook
phpdocumentor> Running phase: buildPhase
phpdocumentor> Executing composerInstallBuildHook
phpdocumentor> Finished composerInstallBuildHook
phpdocumentor> Running phase: checkPhase
phpdocumentor> Executing composerInstallCheckHook
phpdocumentor> Finished composerInstallCheckHook
phpdocumentor> Running phase: installPhase
phpdocumentor> Executing composerInstallInstallHook
phpdocumentor> Creating symlink bin/phpdoc...
phpdocumentor> Creating symlink bin/phpdoc.php...
phpdocumentor> Finished composerInstallInstallHook
phpdocumentor> Running phase: fixupPhase
phpdocumentor> shrinking RPATHs of ELF executables and libraries in /nix/store/ls48ivg6jn95fm7f8ip6207i0ldj90x6-phpdocumentor-3.6.0
phpdocumentor> shrinking /nix/store/ls48ivg6jn95fm7f8ip6207i0ldj90x6-phpdocumentor-3.6.0/bin/phpdoc
phpdocumentor> checking for references to /build/ in /nix/store/ls48ivg6jn95fm7f8ip6207i0ldj90x6-phpdocumentor-3.6.0...
phpdocumentor> patching script interpreter paths in /nix/store/ls48ivg6jn95fm7f8ip6207i0ldj90x6-phpdocumentor-3.6.0
phpdocumentor> /nix/store/ls48ivg6jn95fm7f8ip6207i0ldj90x6-phpdocumentor-3.6.0/share/php/phpdocumentor/bin/phpdoc: interpreter directive changed from "#!/usr/bin/env php" to "/nix/store/r2xq8q0ngikflpnjpbai4pycqkdycikl-php-with-extensions-8.3.15/bin/php"
phpdocumentor> /nix/store/ls48ivg6jn95fm7f8ip6207i0ldj90x6-phpdocumentor-3.6.0/share/php/phpdocumentor/bin/yaml-lint: interpreter directive changed from "#!/usr/bin/env php" to "/nix/store/r2xq8q0ngikflpnjpbai4pycqkdycikl-php-with-extensions-8.3.15/bin/php"
phpdocumentor> /nix/store/ls48ivg6jn95fm7f8ip6207i0ldj90x6-phpdocumentor-3.6.0/share/php/phpdocumentor/bin/githubaction: interpreter directive changed from "#!/usr/bin/env php" to "/nix/store/r2xq8q0ngikflpnjpbai4pycqkdycikl-php-with-extensions-8.3.15/bin/php"
phpdocumentor> /nix/store/ls48ivg6jn95fm7f8ip6207i0ldj90x6-phpdocumentor-3.6.0/share/php/phpdocumentor/bin/phpdoc.php: interpreter directive changed from "#!/usr/bin/env php" to "/nix/store/r2xq8q0ngikflpnjpbai4pycqkdycikl-php-with-extensions-8.3.15/bin/php"
phpdocumentor> /nix/store/ls48ivg6jn95fm7f8ip6207i0ldj90x6-phpdocumentor-3.6.0/share/php/phpdocumentor/tools/box: interpreter directive changed from "#!/usr/bin/env php" to "/nix/store/r2xq8q0ngikflpnjpbai4pycqkdycikl-php-with-extensions-8.3.15/bin/php"
phpdocumentor> /nix/store/ls48ivg6jn95fm7f8ip6207i0ldj90x6-phpdocumentor-3.6.0/share/php/phpdocumentor/vendor/symfony/yaml/Resources/bin/yaml-lint: interpreter directive changed from "#!/usr/bin/env php" to "/nix/store/r2xq8q0ngikflpnjpbai4pycqkdycikl-php-with-extensions-8.3.15/bin/php"
phpdocumentor> /nix/store/ls48ivg6jn95fm7f8ip6207i0ldj90x6-phpdocumentor-3.6.0/share/php/phpdocumentor/vendor/nikic/php-parser/bin/php-parse: interpreter directive changed from "#!/usr/bin/env php" to "/nix/store/r2xq8q0ngikflpnjpbai4pycqkdycikl-php-with-extensions-8.3.15/bin/php"
phpdocumentor> rewriting symlink /nix/store/ls48ivg6jn95fm7f8ip6207i0ldj90x6-phpdocumentor-3.6.0/bin/phpdoc.php to be relative to /nix/store/ls48ivg6jn95fm7f8ip6207i0ldj90x6-phpdocumentor-3.6.0
phpdocumentor> rewriting symlink /nix/store/ls48ivg6jn95fm7f8ip6207i0ldj90x6-phpdocumentor-3.6.0/bin/.phpdoc-wrapped to be relative to /nix/store/ls48ivg6jn95fm7f8ip6207i0ldj90x6-phpdocumentor-3.6.0
~/C/N/nixpkgs > (~push-nvstlwpxlprr (no description set) xlmlx 7b6bce) ❯
| 12:57:24 |
| Pol | This is now fixed :) | 12:57:27 |
| Pol | It's been a while I wanted to see it fixed. | 12:57:38 |
| Pol | The correct SHA is: sha256-LESUhPjpj1KkFkB+JEOCGU9c6LuDQJB5Dtc/q5Bt3Og= | 12:57:51 |
