!jngDrdMgndWibPCYsR:nixos.org

Nix PHP

73 Members
A room for PHP developers running on Nix22 Servers

Load older messages


SenderMessageTime
28 Sep 2024
@drupol:matrix.orgPolOki, thanks20:30:54
@drupol:matrix.orgPolI'll review it tomorrow20:31:01
@tgerbet:matrix.orgtgerbetThanks, to be honest I just opened the PR because it "popped" on my security radar and I saw the usual PHP folks were not it20:35:20
@tgerbet:matrix.orgtgerbetI can dedicate some capacity to work on the backport if needed 🙂20:36:05
@ma27:nicht-so.sexyma27 what confuses me about #345177 is that all the patches are gated behind versionOlder clauses that don't apply for the PHPs we've packaged there. We now have 8.2.24 and 8.3.11, so none of these patches are applied. 20:40:44
@drupol:matrix.orgPolIgnore the PR, I was just trying to backport all the things, without really checking carefully.20:49:47
@drupol:matrix.orgPolI'm also making experimentation with jujutsu ;)20:50:03
29 Sep 2024
@genghiz:cdw.go7box.xyzGenghiz Pol: Is there anything I should change in the privatebin PR? 08:33:01
@drupol:matrix.orgPolyes08:58:45
@drupol:matrix.orgPolIt's missing a test (using runTest)08:58:57
@drupol:matrix.orgPolA very basic test that checks the status code of a curl request for example08:59:23
@genghiz:cdw.go7box.xyzGenghizDone17:36:45
@genghiz:cdw.go7box.xyzGenghizDidn't realise that a test was essential.17:36:58
30 Sep 2024
@drupol:matrix.orgPolit's not essential, but it's a good practice.13:28:25
@drupol:matrix.orgPolI try to add a test to all the services I do13:28:33
@drupol:matrix.orgPolA very simple test is enough13:28:39
@drupol:matrix.orgPol
In reply to @drupol:matrix.org
It's missing a test (using runTest)
Can you please use runTest instead of handleTest? Genghiz ?
13:30:31
@patka:envs.net@patka:envs.net joined the room.13:31:20
@patka:envs.net@patka:envs.net

Hey, just wanted to mention that pretty much everything PHP is not building anymore. All builds seem to fail because of a test in php soap.

If you are interested you can check zh.fail or
https://github.com/NixOS/nixpkgs/issues/345331

(I don't have the time or energy to look into it)

13:34:53
@drupol:matrix.orgPolI don't have the time either, sorry :(13:40:22
@drupol:matrix.orgPolWorking full time on a Python project, I don't remember the last time I did PHP13:40:38
@patka:envs.net@patka:envs.netNo worries at all! Just wanted to at least mention it :)13:41:21
1 Oct 2024
@genghiz:cdw.go7box.xyzGenghiz
In reply to @drupol:matrix.org
Can you please use runTest instead of handleTest? Genghiz ?
Done!
11:43:20
@genghiz:cdw.go7box.xyzGenghiz
In reply to @patka:envs.net

Hey, just wanted to mention that pretty much everything PHP is not building anymore. All builds seem to fail because of a test in php soap.

If you are interested you can check zh.fail or
https://github.com/NixOS/nixpkgs/issues/345331

(I don't have the time or energy to look into it)

Is this still failing? I only see it failing for 8.2 now...
11:50:40
@patka:envs.net@patka:envs.net Yes, it's failing for a _lot_. I just picked a random php maintainer so you can see on the website what fails. It's pretty much all the same error

https://zh.fail/failed/by-maintainer/Ma27.html
11:59:29
@-_o:matrix.org-_o joined the room.21:00:15
3 Oct 2024
@genghiz:cdw.go7box.xyzGenghiz Pol: Could I ask you to merge https://github.com/NixOS/nixpkgs/pull/344014 if it's okay now? I changed the test handler to runTest from handleTest. 17:09:33
@genghiz:cdw.go7box.xyzGenghizAnd this one too? 😬 https://github.com/NixOS/nixpkgs/pull/34524417:09:59
4 Oct 2024
@drupol:matrix.orgPolSorry I'm not always available on Matrix, hence the delay.07:52:13
@drupol:matrix.orgPolI merged the PR.07:52:18

Show newer messages


Back to Room ListRoom Version: 6