!jngDrdMgndWibPCYsR:nixos.org

Nix PHP

67 Members
A room for PHP developers running on Nix20 Servers

Load older messages


SenderMessageTime
23 Sep 2024
@drupol:matrix.orgPolQuick question, how do you usually test PR ? Do you cherry pick the commit in your branch or do another trick ?07:32:17
@genghiz:cdw.go7box.xyzGenghiz
In reply to @drupol:matrix.org
Quick question, how do you usually test PR ? Do you cherry pick the commit in your branch or do another trick ?
I use nixpkgs-review
09:37:35
@drupol:matrix.orgPolBut in this case, you need to test this against fireflii, how do you do then?09:37:58
@genghiz:cdw.go7box.xyzGenghiz

Nixpkgs-review pr -p firefly-iii

09:38:22
@drupol:matrix.orgPolnice09:39:29
@drupol:matrix.orgPolI just notice a small typo09:39:35
@drupol:matrix.orgPolI will fix it after that PR is merged.09:39:42
@drupol:matrix.orgPol setComposeRootVersion -> setComposerRootVersion 09:40:01
@drupol:matrix.orgPol setComposeEnvVariables -> setComposerEnvVariables 09:40:12
@drupol:matrix.orgPolLet me do it within this PR09:40:23
@genghiz:cdw.go7box.xyzGenghizSo firefly-iii seems to be fixed. 09:41:06
@drupol:matrix.orgPolDone, I just fixed the typo09:41:28
@genghiz:cdw.go7box.xyzGenghizOnce you merge I’ll close the firefly-iii fix PR. 09:41:29
@drupol:matrix.orgPolCan you try it again?09:41:40
@drupol:matrix.orgPolAnd post some feedback in the PR ?09:41:45
@genghiz:cdw.go7box.xyzGenghizSame PR number?09:41:48
@drupol:matrix.orgPolyeap09:41:54
@genghiz:cdw.go7box.xyzGenghiz2 mins09:42:10
@genghiz:cdw.go7box.xyzGenghizFwiw the tests work, but I’ll add a properly formatted review message in a bit so just merge post that I think. 10:21:19
@genghiz:cdw.go7box.xyzGenghizThis is a backwards compatible change so I would recommend a backport as well. 10:21:35
@genghiz:cdw.go7box.xyzGenghiz
In reply to @genghiz:cdw.go7box.xyz
Fwiw the tests work, but I’ll add a properly formatted review message in a bit so just merge post that I think.
Done.
10:35:26
@drupol:matrix.orgPolMerged ~!10:59:16
@drupol:matrix.orgPol * Merged !10:59:17
@patka:envs.net@patka:envs.netWhat about the comment I made?11:02:52
@drupol:matrix.orgPolWhich comment? Did I missed something?11:03:55
@patka:envs.net@patka:envs.net

I made a comment on the PR, but it still says pending without a submit button so dont know what went wrong. I'm on mobile in the train now so just

But v1 had COMPOSER_DISABLE_NETWORK = "1"; and I think you forgot to add that in your PR? Or was it purposefully left out?

11:10:51
@drupol:matrix.orgPolLeft out on purpose ;)11:11:43
@drupol:matrix.orgPolNo worries11:11:44
@genghiz:cdw.go7box.xyzGenghiz
In reply to @genghiz:cdw.go7box.xyz
https://github.com/NixOS/nixpkgs/pull/341746

@drupol:matrix.orgHave changed this to not set the variable. It’s a version bump rn. Do have a look.

11:47:51
@drupol:matrix.orgPol So we can now safely say that buildComposerProject2 is stable :) 12:53:13

Show newer messages


Back to Room ListRoom Version: 6