22 Aug 2024 |
piotrkwiecinski | I won't be able to test it for a couple hours | 10:20:08 |
piotrkwiecinski | I have the last day before my annual leave and have to wrap up few things at work | 10:20:38 |
piotrkwiecinski | https://github.com/composer/composer/blob/main/src/Composer/Autoload/AutoloadGenerator.php#L569-L582 | 10:22:33 |
piotrkwiecinski | it's the block to debug | 10:23:08 |
24 Aug 2024 |
| Rogier Knoester joined the room. | 15:25:03 |
27 Aug 2024 |
@genghiz:talk.go7box.xyz | Hey guys, can someone have a look at this PHP PR? Packages firefly-iii data importer https://github.com/NixOS/nixpkgs/pull/331823 | 19:42:47 |
28 Aug 2024 |
fsagbuya | I also would like to follow up on this PR: https://github.com/NixOS/nixpkgs/pull/336044. Pol | 02:48:41 |
2 Sep 2024 |
Pol | piotrkwiecinski: Did you had the time to revisit the composer issue ? | 17:25:08 |
Pol | On my side, big nope :( | 17:25:13 |
6 Sep 2024 |
piotrkwiecinski | Pol: I just finished my vacations. Didn't have access to my laptop for almost 2 weeks. | 16:54:58 |
7 Sep 2024 |
Pol | In reply to @piotrkwiecinski:matrix.org Pol: I just finished my vacations. Didn't have access to my laptop for almost 2 weeks. Lucky you | 09:04:28 |
13 Sep 2024 |
| @genghiz:talk.go7box.xyz left the room. | 15:29:43 |
| @genghiz:talk.go7box.xyz joined the room. | 19:06:31 |
16 Sep 2024 |
| silentlurker joined the room. | 20:01:03 |
17 Sep 2024 |
@genghiz:talk.go7box.xyz | Hey all | 13:32:55 |
@genghiz:talk.go7box.xyz | There's an issue I've been tagged in (https://github.com/NixOS/nixpkgs/issues/342285#issuecomment-2353988357) where I think I know what's going wrong, but I don't know how to debug it. | 13:33:40 |
@genghiz:talk.go7box.xyz | There seems to be an issue in the current version of composer on master wherein certain symlinks in the vendor directory aren't being generated properly. | 13:34:16 |
@genghiz:talk.go7box.xyz | So basically unless one doesn't set COMPOSER_MIRROR_PATH_REPOS = "1" in a php build, the package doesn't work properly. | 14:18:28 |
@genghiz:talk.go7box.xyz | * So basically unless one doesn't set COMPOSER_MIRROR_PATH_REPOS = "1" in a php package build, the package doesn't work properly. | 14:18:36 |
Pol | catman: Could you make the PR to set that variable by default? | 14:46:04 |
@genghiz:talk.go7box.xyz | It's set to by default here https://github.com/NixOS/nixpkgs/blob/master/pkgs/build-support/php/builders/v1/build-composer-project.nix | 14:54:48 |
@genghiz:talk.go7box.xyz | * It's set by default here https://github.com/NixOS/nixpkgs/blob/master/pkgs/build-support/php/builders/v1/build-composer-project.nix | 14:54:53 |
@genghiz:talk.go7box.xyz | I'll probably have to set it here https://github.com/NixOS/nixpkgs/blob/master/pkgs/build-support/php/builders/v1/hooks/composer-install-hook.sh | 14:55:34 |
@genghiz:talk.go7box.xyz | Would that work? | 14:55:37 |
@genghiz:talk.go7box.xyz | Before line 106, I think | 14:55:51 |
Pol | Then it should be set | 15:01:32 |
Pol | I don't think we should add anything if it's already there. | 15:01:42 |
Pol | Weird stuff. | 15:01:49 |
@genghiz:talk.go7box.xyz | It needs to be manually set if one isn't using buildComposerProject and using hooks on their own like in firefly-iii | 15:08:18 |
Pol | Oh, good point. | 15:09:57 |