!jngDrdMgndWibPCYsR:nixos.org

Nix PHP

74 Members
A room for PHP developers running on Nix23 Servers

Load older messages


SenderMessageTime
21 Aug 2024
@drupol:matrix.orgPolI have some kind of hard deadline for the moment, and I can't do anything else.19:16:40
@piotrkwiecinski:matrix.orgpiotrkwiecinskiafter getPathCode19:16:47
@drupol:matrix.orgPolJust shove it in getPathCode so it's cleaner.19:17:09
@piotrkwiecinski:matrix.orgpiotrkwiecinski
        $exportedPaths = [];
        foreach ($paths as $path) {
            $exportedPaths[] = $this->getPathCode($filesystem, $basePath, $vendorPath, $path);
        }
19:17:31
@piotrkwiecinski:matrix.orgpiotrkwiecinskigetPathCode is a string19:17:38
@piotrkwiecinski:matrix.orgpiotrkwiecinskiso we have to sort the array after it's generated19:18:04
@drupol:matrix.orgPolhttps://github.com/composer/composer/blob/main/src/Composer/Autoload/AutoloadGenerator.php#L735C15-L735C35 19:19:03
@drupol:matrix.orgPolOh wait.19:19:15
@drupol:matrix.orgPolyou're right. sorry.19:19:26
@drupol:matrix.orgPol I guess it's a missing sort somewhere before that. 19:20:01
22 Aug 2024
@drupol:matrix.orgPol piotrkwiecinski: I cannot reproduce the issue with the patch you provided. 04:33:45
@drupol:matrix.orgPol I get a stable hash for phpdocumentor with it: sha256-LFrkJaFfMzNWOgeUXrNLLURpMt0eNqCUHcTYnIcQJqk= 04:34:17
@drupol:matrix.orgPolOK, got a working patch, plus a refactoring, plus the tests updated.05:21:27
@drupol:matrix.orgPolLet me know if this is OK for you: https://github.com/composer/composer/pull/1209005:29:02
@drupol:matrix.orgPolAllrighty, I won't be able to take care of this today, I have to switch to something else now.05:46:22
@drupol:matrix.orgPolI'll check here from time to time without being able to produce code if needed.05:46:40
@piotrkwiecinski:matrix.orgpiotrkwiecinski Thank you Pol for picking it up. 06:46:19
@drupol:matrix.orgPolYou did the job mate... I just created the PR to fix that issue ASAP.06:46:37
@drupol:matrix.orgPol piotrkwiecinski: https://github.com/composer/composer/pull/12090#discussion_r1726756464 10:16:38
@piotrkwiecinski:matrix.orgpiotrkwiecinskiI saw the comment10:18:57
@piotrkwiecinski:matrix.orgpiotrkwiecinski
    $psr0 = $this->parseAutoloadsType($packageMap, 'psr-0', $rootPackage);
    $psr4 = $this->parseAutoloadsType($packageMap, 'psr-4', $rootPackage);
    $classmap = $this->parseAutoloadsType(array_reverse($sortedPackageMap), 'classmap', $rootPackage);
    $files = $this->parseAutoloadsType($sortedPackageMap, 'files', $rootPackage);
    $exclude = $this->parseAutoloadsType($sortedPackageMap, 'exclude-from-classmap', $rootPackage);
10:18:59
@piotrkwiecinski:matrix.orgpiotrkwiecinskipsr4 doesn't seem to use sorted map10:19:16
@piotrkwiecinski:matrix.orgpiotrkwiecinskimaybe this is the problem10:19:56
@piotrkwiecinski:matrix.orgpiotrkwiecinskiI won't be able to test it for a couple hours10:20:08
@piotrkwiecinski:matrix.orgpiotrkwiecinskiI have the last day before my annual leave and have to wrap up few things at work10:20:38
@piotrkwiecinski:matrix.orgpiotrkwiecinskihttps://github.com/composer/composer/blob/main/src/Composer/Autoload/AutoloadGenerator.php#L569-L58210:22:33
@piotrkwiecinski:matrix.orgpiotrkwiecinskiit's the block to debug10:23:08
24 Aug 2024
@rogierknoester:matrix.orgRogier Knoester joined the room.15:25:03
27 Aug 2024
@genghiz:talk.go7box.xyz@genghiz:talk.go7box.xyzHey guys, can someone have a look at this PHP PR? Packages firefly-iii data importer https://github.com/NixOS/nixpkgs/pull/33182319:42:47
28 Aug 2024
@fsagbuya:matrix.orgfsagbuya I also would like to follow up on this PR: https://github.com/NixOS/nixpkgs/pull/336044. Pol 02:48:41

Show newer messages


Back to Room ListRoom Version: 6