!jngDrdMgndWibPCYsR:nixos.org

Nix PHP

73 Members
A room for PHP developers running on Nix22 Servers

You have reached the beginning of time (for this room).


SenderMessageTime
21 Aug 2024
@piotrkwiecinski:matrix.orgpiotrkwiecinskiThese paths are part of PSR4 logic18:39:01
@piotrkwiecinski:matrix.orgpiotrkwiecinskiIf I read it correctly autoload_psr4.php is generated first and is used by autoload_static.php18:40:26
@piotrkwiecinski:matrix.orgpiotrkwiecinskihttps://github.com/composer/composer/blob/main/src/Composer/Autoload/AutoloadGenerator.php#L263-L287 it's a good starting point for debugging18:49:59
@drupol:matrix.orgPol Most probably that the function getPathCode is missing a sort somewhere. 19:16:11
@drupol:matrix.orgPolBut I cannot have a look at this before next week19:16:24
@piotrkwiecinski:matrix.orgpiotrkwiecinskiI'm trying to see if adding sort before they are saved to file helps19:16:28
@drupol:matrix.orgPolI have some kind of hard deadline for the moment, and I can't do anything else.19:16:40
@piotrkwiecinski:matrix.orgpiotrkwiecinskiafter getPathCode19:16:47
@drupol:matrix.orgPolJust shove it in getPathCode so it's cleaner.19:17:09
@piotrkwiecinski:matrix.orgpiotrkwiecinski
        $exportedPaths = [];
        foreach ($paths as $path) {
            $exportedPaths[] = $this->getPathCode($filesystem, $basePath, $vendorPath, $path);
        }
19:17:31
@piotrkwiecinski:matrix.orgpiotrkwiecinskigetPathCode is a string19:17:38
@piotrkwiecinski:matrix.orgpiotrkwiecinskiso we have to sort the array after it's generated19:18:04
@drupol:matrix.orgPolhttps://github.com/composer/composer/blob/main/src/Composer/Autoload/AutoloadGenerator.php#L735C15-L735C35 19:19:03
@drupol:matrix.orgPolOh wait.19:19:15
@drupol:matrix.orgPolyou're right. sorry.19:19:26
@drupol:matrix.orgPol I guess it's a missing sort somewhere before that. 19:20:01
22 Aug 2024
@drupol:matrix.orgPol piotrkwiecinski: I cannot reproduce the issue with the patch you provided. 04:33:45
@drupol:matrix.orgPol I get a stable hash for phpdocumentor with it: sha256-LFrkJaFfMzNWOgeUXrNLLURpMt0eNqCUHcTYnIcQJqk= 04:34:17
@drupol:matrix.orgPolOK, got a working patch, plus a refactoring, plus the tests updated.05:21:27
@drupol:matrix.orgPolLet me know if this is OK for you: https://github.com/composer/composer/pull/1209005:29:02

Show newer messages


Back to Room ListRoom Version: 6