20 Aug 2024 |
piotrkwiecinski | I'm slowly fixing php builds | 17:55:44 |
piotrkwiecinski | 68 pass, 40 to go | 17:55:59 |
Pol | Thank you once again!!! | 18:05:10 |
Pol | piotrkwiecinski: Looks like the issue is in the autoloader generation in Composer... | 21:32:05 |
Pol |  Download image.png | 21:32:10 |
21 Aug 2024 |
fsagbuya | In reply to @drupol:matrix.org Done :) Cheers! Will try this soon to replace the changes in this PR: https://github.com/NixOS/nixpkgs/pull/336044, likely when it's already available in the unstable branch. | 02:19:50 |
piotrkwiecinski | Pol: I reckon it's caused by --optimize-autoloader | 06:50:01 |
piotrkwiecinski | I removed it from composer-vendor-hook.sh and I get the same hash every run. At least at the moment. | 06:52:15 |
piotrkwiecinski | Adding sort in both places maybe will help:
https://github.com/composer/composer/blob/main/src/Composer/Autoload/AutoloadGenerator.php#L268
https://github.com/composer/composer/blob/main/src/Composer/Autoload/AutoloadGenerator.php#L280
| 07:09:01 |
Pol | In reply to @fsagbuya:matrix.org Cheers! Will try this soon to replace the changes in this PR: https://github.com/NixOS/nixpkgs/pull/336044, likely when it's already available in the unstable branch. Wait a bit, we identified an issue in the buildComposerProject2 . We need to fix it asap before promoting the new builder. | 07:33:21 |
piotrkwiecinski | Pol: | 18:37:55 |
piotrkwiecinski | * Pol: I'm doing some digging into composer issue | 18:38:06 |
piotrkwiecinski | These paths are part of PSR4 logic | 18:39:01 |
piotrkwiecinski | If I read it correctly autoload_psr4.php is generated first and is used by autoload_static.php | 18:40:26 |
piotrkwiecinski | https://github.com/composer/composer/blob/main/src/Composer/Autoload/AutoloadGenerator.php#L263-L287 it's a good starting point for debugging | 18:49:59 |
Pol | Most probably that the function getPathCode is missing a sort somewhere. | 19:16:11 |
Pol | But I cannot have a look at this before next week | 19:16:24 |
piotrkwiecinski | I'm trying to see if adding sort before they are saved to file helps | 19:16:28 |