| 17 Aug 2024 |
 Pol | Just added you as maintainer | 18:10:03 |
 piotrkwiecinski | Got it. Thank you. I have 59 builds passing. Still 49 to go. It'll probably take at least a couple days. | 18:18:25 |
| Pol | there's no hurry | 18:44:07 |
| 18 Aug 2024 |
|  @genghiz:talk.go7box.xyz | 19:03:37 |
| 20 Aug 2024 |
|  fsagbuya joined the room. | 08:58:03 |
| fsagbuya | Hi. Is there a good way to extend a certain package with a php extension using buildComposerProject? I managed to do that by making the following changes:
git diff pkgs/by-name/fl/flarum/package.nix
diff --git a/pkgs/by-name/fl/flarum/package.nix b/pkgs/by-name/fl/flarum/package.nix
index ee38394cd1a5..f37d7349bc06 100644
--- a/pkgs/by-name/fl/flarum/package.nix
+++ b/pkgs/by-name/fl/flarum/package.nix
@@ -14,9 +14,18 @@ php.buildComposerProject (finalAttrs: {
hash = "sha256-kigUZpiHTM24XSz33VQYdeulG1YI5s/M02V7xue72VM=";
};
+ postPatch = ''
+ substituteInPlace composer.json \
+ --replace '"flarum/core": "^1.8"' \
+ '"flarum/core": "^1.8",
+ "fof/polls": "*",
+ "fof/subscribed": "*",
+ "fof/upload": "*"'
+ '';
+
composerLock = ./composer.lock;
composerStrictValidation = false;
- vendorHash = "sha256-gQkjuatItw93JhI7FVfg5hYxkC1gsRQ3c2C2+MhI/Jg=";
+ vendorHash = "sha256-GUyBQ9uv6i99ICz4AaV1okmXdVF6TebBX6OQtUaXwJw=";
meta = with lib; {
changelog = "https://github.com/flarum/framework/blob/main/CHANGELOG.md";
However, I'm not sure if this is the proper way. Is there an extension management system for php packages similar to what's available for vscode?
| 09:05:28 |
| fsagbuya | * Hi. Is there a good way to extend a certain package with a php extension using buildComposerProject? I managed to do that by making the following changes:
git diff pkgs/by-name/fl/flarum/package.nix
diff --git a/pkgs/by-name/fl/flarum/package.nix b/pkgs/by-name/fl/flarum/package.nix
index ee38394cd1a5..f37d7349bc06 100644
--- a/pkgs/by-name/fl/flarum/package.nix
+++ b/pkgs/by-name/fl/flarum/package.nix
@@ -14,9 +14,18 @@ php.buildComposerProject (finalAttrs: {
hash = "sha256-kigUZpiHTM24XSz33VQYdeulG1YI5s/M02V7xue72VM=";
};
+ postPatch = ''
+ substituteInPlace composer.json \
+ --replace '"flarum/core": "^1.8"' \
+ '"flarum/core": "^1.8",
+ "fof/polls": "*",
+ "fof/subscribed": "*",
+ "fof/upload": "*"'
+ '';
+
composerLock = ./composer.lock;
composerStrictValidation = false;
- vendorHash = "sha256-gQkjuatItw93JhI7FVfg5hYxkC1gsRQ3c2C2+MhI/Jg=";
+ vendorHash = "sha256-GUyBQ9uv6i99ICz4AaV1okmXdVF6TebBX6OQtUaXwJw=";
meta = with lib; {
changelog = "https://github.com/flarum/framework/blob/main/CHANGELOG.md";
However, I'm not sure if this is the proper way. Is there an extension management system for php packages similar to what's available for vscode?
| 09:05:57 |
| fsagbuya | * Hi. Is there a good way to extend a certain package with a php extension using buildComposerProject? I managed to do that by making the following changes:
diff --git a/pkgs/by-name/fl/flarum/package.nix b/pkgs/by-name/fl/flarum/package.nix
index ee38394cd1a5..f37d7349bc06 100644
--- a/pkgs/by-name/fl/flarum/package.nix
+++ b/pkgs/by-name/fl/flarum/package.nix
@@ -14,9 +14,18 @@ php.buildComposerProject (finalAttrs: {
hash = "sha256-kigUZpiHTM24XSz33VQYdeulG1YI5s/M02V7xue72VM=";
};
+ postPatch = ''
+ substituteInPlace composer.json \
+ --replace '"flarum/core": "^1.8"' \
+ '"flarum/core": "^1.8",
+ "fof/polls": "*",
+ "fof/subscribed": "*",
+ "fof/upload": "*"'
+ '';
+
composerLock = ./composer.lock;
composerStrictValidation = false;
- vendorHash = "sha256-gQkjuatItw93JhI7FVfg5hYxkC1gsRQ3c2C2+MhI/Jg=";
+ vendorHash = "sha256-GUyBQ9uv6i99ICz4AaV1okmXdVF6TebBX6OQtUaXwJw=";
meta = with lib; {
changelog = "https://github.com/flarum/framework/blob/main/CHANGELOG.md";
However, I'm not sure if this is the proper way. Is there an extension management system for php packages similar to what's available for vscode?
| 09:06:13 |
| Pol | I think this is the way to go. Either that or a .patch. | 09:14:53 |
| Pol | Isn't this supposed to be fixed upstream? | 09:15:20 |
| fsagbuya | The upstream package is only the base installation; however, these are good extensions to add for the Flarum package, and that is how we used it. I only added this in my local nixpkgs because some users may not want to enable it. I can push these packages if it's alright. Although, I'm thinking there might be a way to make this optional. | 09:19:34 |
| fsagbuya | In reply to @drupol:matrix.org
I think this is the way to go. Either that or a .patch. an optional .patch is a good idea too | 09:22:51 |
| Pol | composer doesn't have, like python, a way to compose groups of dependencies. | 09:41:45 |
