| 17 Aug 2024 |
 piotrkwiecinski | I was able to fix 20 jobs yesterday https://github.com/piotrkwiecinski/php-src-nix/pull/1 | 08:50:43 |
 Pol | man, wow ! Impressive !!! | 08:51:45 |
| piotrkwiecinski | There is fair amount of copy/paste. For now I plan to ensure all of them are green and see I can simply it | 08:51:47 |
| Pol | submit the PR against loophp/php-src-nix | 08:52:07 |
| Pol | If you want I can make you maintainer too | 08:52:15 |
| piotrkwiecinski | I'll PR it against loophp once it's ready. If you don't mind me being a maintainer. I'm happy to help. | 08:55:20 |
| piotrkwiecinski | I'm going to use php for at least a couple years | 08:55:53 |
| piotrkwiecinski | I start to think maybe we should rework patches in nixpkgs | 09:44:03 |
| piotrkwiecinski | Overlay relies on https://github.com/piotrkwiecinski/php-src-nix/blob/main/src/makePhpPackage.nix#L13 | 09:45:15 |
| piotrkwiecinski | this means version specific patches from nixpkgs aren't applied | 09:45:36 |
| piotrkwiecinski | we would have to move https://github.com/piotrkwiecinski/nixpkgs/blob/fa088a9477b35d8e36c8204c35fc574eaffe0190/pkgs/development/interpreters/php/8.1.nix#L7-L31 to generic.nix | 09:46:12 |
| piotrkwiecinski | it would make backporting easier | 09:46:28 |
| Pol | yeah there are some improvements to be made. | 18:09:57 |
