| 22 Sep 2024 |
 patka | When that's merged I'll bump all php packages. Probably the psysh issue will then also be fixed | 17:36:32 |
 Pol | Thank you patka Just merged it. | 19:03:26 |
| 23 Sep 2024 |
| patka | I fixed nix-update, but my PR still has an error in a (python) test. I tested it manually and it works, just this test is somehow broken.
Maybe anyone here feels like having a look? https://github.com/Mic92/nix-update/pull/283 | 06:27:27 |
| Pol | patka: Do you have a clue for this? https://github.com/NixOS/nixpkgs/pull/341746#pullrequestreview-2321219018 | 06:52:27 |
 Genghiz | @drupol:matrix.org I’ve added PR 343898 which solves this issue.
| 07:17:08 |
| Genghiz | It should clear it up for all packages built like firefly-iii | 07:17:23 |
| Genghiz | But if possible do run the check locally and make sure of it. | 07:17:55 |
| Pol | Genghiz: I have some thing a bit more advanced | 07:17:58 |
| Genghiz | Oo | 07:18:03 |
| Genghiz | Tell me more? | 07:18:09 |
| Pol | Let me share it in a PR in 2 minutes | 07:18:27 |
| Genghiz | Awesome. | 07:18:34 |
| patka | So this means I don't have to look and there's already a solution? | 07:19:58 |
| Pol | https://github.com/NixOS/nixpkgs/pull/343900 | 07:21:21 |
| Pol | patka: Yeah :) | 07:21:30 |
| Pol | patka: I've also fixed this: https://github.com/NixOS/nixpkgs/pull/343900/commits/3bcaabbb7119cb06f7f79770baf2e11ad293955c | 07:21:45 |
| patka | Oopsie, thanks! | 07:23:59 |
| patka | Just have a small question on the PR above. Apart from that it looks good. Genghiz would you be able to test that it works with the firefly-iii work? | 07:25:48 |
| patka | * Just have a small question on the PR above. Apart from that it looks good. Genghiz would you be able to test/validate that it works with the firefly-iii work? | 07:26:05 |
| Genghiz | In reply to @patka:envs.net
Just have a small question on the PR above. Apart from that it looks good. Genghiz would you be able to test/validate that it works with the firefly-iii work? Gimme an hour I’ll do that. | 07:29:47 |
| Pol | Quick question, how do you usually test PR ? Do you cherry pick the commit in your branch or do another trick ? | 07:32:17 |
| Genghiz | In reply to @drupol:matrix.org
Quick question, how do you usually test PR ? Do you cherry pick the commit in your branch or do another trick ? I use nixpkgs-review | 09:37:35 |
| Pol | But in this case, you need to test this against fireflii, how do you do then? | 09:37:58 |
| Genghiz | Nixpkgs-review pr -p firefly-iii
| 09:38:22 |
| Pol | nice | 09:39:29 |
| Pol | I just notice a small typo | 09:39:35 |
| Pol | I will fix it after that PR is merged. | 09:39:42 |
| Pol | setComposeRootVersion -> setComposerRootVersion | 09:40:01 |
| Pol | setComposeEnvVariables -> setComposerEnvVariables | 09:40:12 |
| Pol | Let me do it within this PR | 09:40:23 |
