| 17 Sep 2024 |
 @genghiz:talk.go7box.xyz | So basically unless one doesn't set COMPOSER_MIRROR_PATH_REPOS = "1" in a php build, the package doesn't work properly. | 14:18:28 |
| @genghiz:talk.go7box.xyz | * So basically unless one doesn't set COMPOSER_MIRROR_PATH_REPOS = "1" in a php package build, the package doesn't work properly. | 14:18:36 |
 Pol | catman: Could you make the PR to set that variable by default? | 14:46:04 |
| @genghiz:talk.go7box.xyz | It's set to by default here https://github.com/NixOS/nixpkgs/blob/master/pkgs/build-support/php/builders/v1/build-composer-project.nix | 14:54:48 |
| @genghiz:talk.go7box.xyz | * It's set by default here https://github.com/NixOS/nixpkgs/blob/master/pkgs/build-support/php/builders/v1/build-composer-project.nix | 14:54:53 |
| @genghiz:talk.go7box.xyz | I'll probably have to set it here https://github.com/NixOS/nixpkgs/blob/master/pkgs/build-support/php/builders/v1/hooks/composer-install-hook.sh | 14:55:34 |
| @genghiz:talk.go7box.xyz | Would that work? | 14:55:37 |
| @genghiz:talk.go7box.xyz | Before line 106, I think | 14:55:51 |
| Pol | Then it should be set | 15:01:32 |
| Pol | I don't think we should add anything if it's already there. | 15:01:42 |
| Pol | Weird stuff. | 15:01:49 |
| @genghiz:talk.go7box.xyz | It needs to be manually set if one isn't using buildComposerProject and using hooks on their own like in firefly-iii | 15:08:18 |
| Pol | Oh, good point. | 15:09:57 |
| Pol | Feel free to make the PR, I'll merge it immediatelly. | 15:10:08 |
| @genghiz:talk.go7box.xyz | I'll do that | 15:17:02 |
| @genghiz:talk.go7box.xyz | But wait, Pol we'll be using v2 for all this soon no? | 15:17:25 |
| @genghiz:talk.go7box.xyz | So would it be better to hack on v2? | 15:17:33 |
| Pol | I wish I could work on that, but at the moment I don't have time to work on PHP stuff as I explained here : https://matrix.to/#/!jngDrdMgndWibPCYsR:nixos.org/$migGCKHgSgsYNWy43DMMZ8SEbyYtgglwWHAP47tHppc?via=nixos.org&via=matrix.org&via=nixos.dev | 15:18:57 |
| Pol | So I'm ready to quickly review stuff, but involving myself in the builders at the moment is impossible. | 15:19:17 |
| @genghiz:talk.go7box.xyz | Oh wow | 15:21:28 |
| @genghiz:talk.go7box.xyz | I missed that message it seems | 15:21:33 |
| @genghiz:talk.go7box.xyz | Congrats on the thesis. :) | 15:21:39 |
| @genghiz:talk.go7box.xyz | In reply to @drupol:matrix.org
So I'm ready to quickly review stuff, but involving myself in the builders at the moment is impossible. Fair enough on this. | 15:21:49 |
| Pol | Thank you <3 | 15:22:04 |
| @genghiz:talk.go7box.xyz | I've been meaning to look at the builders for a while now. They're in bash, so easy enough to look at. | 15:22:58 |
| Pol | Yes, we need resources, they are trivial | 15:23:17 |
| @genghiz:talk.go7box.xyz | Had been thinking of putting some rudimentary rust skills to use by writing something, but I'm no software dev so I'll probably take some time to write | 15:23:26 |
| Pol | The v2 of the builder is currently unstable and therefore, unusable. | 15:23:30 |
| @genghiz:talk.go7box.xyz | For a php builder that is | 15:23:33 |
| @genghiz:talk.go7box.xyz | Ah | 15:23:35 |
