13 Sep 2024 |
| @genghiz:talk.go7box.xyz joined the room. | 19:06:31 |
16 Sep 2024 |
| silentlurker joined the room. | 20:01:03 |
17 Sep 2024 |
@genghiz:talk.go7box.xyz | Hey all | 13:32:55 |
@genghiz:talk.go7box.xyz | There's an issue I've been tagged in (https://github.com/NixOS/nixpkgs/issues/342285#issuecomment-2353988357) where I think I know what's going wrong, but I don't know how to debug it. | 13:33:40 |
@genghiz:talk.go7box.xyz | There seems to be an issue in the current version of composer on master wherein certain symlinks in the vendor directory aren't being generated properly. | 13:34:16 |
@genghiz:talk.go7box.xyz | So basically unless one doesn't set COMPOSER_MIRROR_PATH_REPOS = "1" in a php build, the package doesn't work properly. | 14:18:28 |
@genghiz:talk.go7box.xyz | * So basically unless one doesn't set COMPOSER_MIRROR_PATH_REPOS = "1" in a php package build, the package doesn't work properly. | 14:18:36 |
Pol | catman: Could you make the PR to set that variable by default? | 14:46:04 |
@genghiz:talk.go7box.xyz | It's set to by default here https://github.com/NixOS/nixpkgs/blob/master/pkgs/build-support/php/builders/v1/build-composer-project.nix | 14:54:48 |
@genghiz:talk.go7box.xyz | * It's set by default here https://github.com/NixOS/nixpkgs/blob/master/pkgs/build-support/php/builders/v1/build-composer-project.nix | 14:54:53 |
@genghiz:talk.go7box.xyz | I'll probably have to set it here https://github.com/NixOS/nixpkgs/blob/master/pkgs/build-support/php/builders/v1/hooks/composer-install-hook.sh | 14:55:34 |
@genghiz:talk.go7box.xyz | Would that work? | 14:55:37 |
@genghiz:talk.go7box.xyz | Before line 106, I think | 14:55:51 |
Pol | Then it should be set | 15:01:32 |
Pol | I don't think we should add anything if it's already there. | 15:01:42 |
Pol | Weird stuff. | 15:01:49 |
@genghiz:talk.go7box.xyz | It needs to be manually set if one isn't using buildComposerProject and using hooks on their own like in firefly-iii | 15:08:18 |
Pol | Oh, good point. | 15:09:57 |
Pol | Feel free to make the PR, I'll merge it immediatelly. | 15:10:08 |
@genghiz:talk.go7box.xyz | I'll do that | 15:17:02 |
@genghiz:talk.go7box.xyz | But wait, Pol we'll be using v2 for all this soon no? | 15:17:25 |
@genghiz:talk.go7box.xyz | So would it be better to hack on v2? | 15:17:33 |
Pol | I wish I could work on that, but at the moment I don't have time to work on PHP stuff as I explained here : https://matrix.to/#/!jngDrdMgndWibPCYsR:nixos.org/$migGCKHgSgsYNWy43DMMZ8SEbyYtgglwWHAP47tHppc?via=nixos.org&via=matrix.org&via=nixos.dev | 15:18:57 |
Pol | So I'm ready to quickly review stuff, but involving myself in the builders at the moment is impossible. | 15:19:17 |
@genghiz:talk.go7box.xyz | Oh wow | 15:21:28 |
@genghiz:talk.go7box.xyz | I missed that message it seems | 15:21:33 |
@genghiz:talk.go7box.xyz | Congrats on the thesis. :) | 15:21:39 |
@genghiz:talk.go7box.xyz | In reply to @drupol:matrix.org So I'm ready to quickly review stuff, but involving myself in the builders at the moment is impossible. Fair enough on this. | 15:21:49 |
Pol | Thank you <3 | 15:22:04 |
@genghiz:talk.go7box.xyz | I've been meaning to look at the builders for a while now. They're in bash, so easy enough to look at. | 15:22:58 |