| 14 Aug 2024 |
 piotrkwiecinski | patches = lib.optional (lib.versionOlder version "8.4.0beta1") [
./fix-paths-php7.patch
] ++ lib.optional (lib.versionAtLeast version "8.4.0beta1") [
./fix-paths-php84.patch
] ++ extraPatches;
| 13:28:00 |
| piotrkwiecinski | if this works as expected i can PR it earlier | 13:28:50 |
| piotrkwiecinski | ok seems to build | 13:31:37 |
 Pol | no | 13:31:40 |
| Pol | By using lib.optional <predicate> [ ], you're wrapping twice. | 13:32:04 |
| Pol | In this case, you have to use lib.optionals <predicate> [ ] | 13:32:20 |
| Pol | (hense the s) | 13:32:28 |
| piotrkwiecinski | somehow it built without s too | 13:34:28 |
| piotrkwiecinski | and applied the patch | 13:34:40 |
| piotrkwiecinski | on I changed it to s | 13:35:53 |
| piotrkwiecinski | so in theory it shouldn't break current 8.4.0alpha1 | 13:36:21 |
| Pol | We can already use beta1 I think | 13:40:12 |
| piotrkwiecinski | we have alpha | 13:40:24 |
| Pol | beta1 : https://downloads.php.net/~calvinb/ | 13:40:45 |
| piotrkwiecinski | alpha4 | 13:40:47 |
| Pol | alpha4 and beta1 are available | 13:40:55 |
| piotrkwiecinski | in our repo i mean | 13:40:58 |
| Pol | ah ok | 13:41:02 |
| Pol | #324831 php84: init at 8.4.0alpha1 ✅ staging-next ✅ master ✅ nixos-unstable-small ⏳nixos-unstable ⏳nixpkgs-unstable | 13:42:41 |
| Pol | It will be soon available on nixos-unstable! | 13:42:54 |
| piotrkwiecinski | it's in master so I can PR update to beta | 13:43:56 |
| Pol | Yes | 13:44:54 |
| piotrkwiecinski | Could you merge https://github.com/NixOS/nixpkgs/pull/334411 in meantime? I may have conflicts in php-packages.nix | 13:48:54 |
| Pol | yes | 14:52:32 |
| Pol | Done. | 14:55:24 |
| piotrkwiecinski | Pol: are you saying that php8.4 update won't be merged til the official release in nov? I though you wanted to have a fix for https://github.com/loophp/php-src-nix/actions/runs/10364035720/job/28688711194 | 15:08:56 |
| Pol | Php 8.4 beta1 will be announced these days, no worries. | 15:13:45 |
| Pol | Once it's updated, we test once more the build to make sure that they didn't updated the tarball, then we merge it | 15:14:03 |
| piotrkwiecinski | Ah I beta1 announcement I thought it'll be stuck until the general release :). I misread the comment. | 15:15:09 |
| Pol | ;) | 15:16:26 |
