| 16 May 2024 |
 @drupol:matrix.org | I'm making plenty of experimentation at the moment with the version 2 of the PHP builder. | 12:36:57 |
| @drupol:matrix.org | * I'm making plenty of experimentations at the moment with the version 2 of the PHP builder. | 12:37:03 |
| @drupol:matrix.org | I was looking for a cleaner way to use Composer plugins. | 12:37:13 |
| @drupol:matrix.org | Had to work on this yesterday and today at work. | 12:37:23 |
| @drupol:matrix.org | I finally came up with this interface: https://github.com/NixOS/nixpkgs/pull/308059/commits/29d9c8a602875fe096eb35fc60dd1b1ece510e8d | 12:37:32 |
| @drupol:matrix.org | This works, but I don't know if it's the best way to do that. | 12:37:53 |
| @drupol:matrix.org | Feel free to hack and participate in the PR at https://github.com/NixOS/nixpkgs/pull/308059 | 12:38:06 |
| @drupol:matrix.org | Thanks to this, I can fix some bad design from version 1: https://github.com/NixOS/nixpkgs/pull/308059/commits/133d96cb6a70582d65ae8161906c4c4823457bd1 | 13:16:38 |
| @drupol:matrix.org | I will most probably split that PR in multiple PR, trying to backport the good thing before introducing the version 2. | 13:16:57 |
| @drupol:matrix.org | A lot of work ahead to avoid breaking everything. | 13:17:04 |
| @drupol:matrix.org | Any small help is very welcome. | 13:17:11 |
| @drupol:matrix.org | Here's some backport for the builder version 1: https://github.com/NixOS/nixpkgs/pull/312231 | 15:07:28 |
| @drupol:matrix.org | I think I'm done with that PR. | 16:14:42 |
| @drupol:matrix.org | I'm happy enough... until someone will make a review and will kill my modjo :D looking at you Jan Tojnar ! :D :D :D | 16:15:13 |
| @drupol:matrix.org | Redacted or Malformed Event | 16:16:52 |
| 17 May 2024 |
| @drupol:matrix.org | This morning I rewrote the PR https://github.com/NixOS/nixpkgs/pull/312231, the new builder look like the existing builder now, with finalAttrs override stuff. Everything works great, I'm extremelly satisfied of the result. | 08:38:46 |
| @drupol:matrix.org | Given the amount of work in this PR, I'll merge it in one week if I don't have feedback. The easiest way to review it is going commit per commit. | 08:39:17 |
 @patka_123:matrix.org | I will gladly review it, but I currently don't have the bandwith. And you probably want someone more experienced as well | 09:43:04 |
| @drupol:matrix.org | No worries it's fine | 10:07:11 |
 piotrkwiecinski | Hi everyone. When https://github.com/NixOS/nixpkgs/pull/308059 is ready feel free to ping me and I'm happy to help with migrating php package to v2 builder, so you can focus on more tasks. | 12:11:19 |
| @drupol:matrix.org | v2 is not going to be out "soon". | 12:13:37 |
| @drupol:matrix.org | The PR https://github.com/NixOS/nixpkgs/pull/312231 needs to comes first, then I'll rebase the PR for the V2 builder on it. | 12:13:59 |
| piotrkwiecinski | I saw it as well but I'm not experienced enough to review it. I can help with reviewing PHP package updates if that helps. | 12:18:38 |
| @patka_123:matrix.org | There are not many. If you want you could go through the list to find out if something needs to be updated? | 12:21:54 |
| @drupol:matrix.org | I would not advise to update hashes now. | 12:28:27 |
| @drupol:matrix.org | I would wait a bit I stabilize the new V2 builder. | 12:28:39 |
| @drupol:matrix.org | If you really would like to help is by reviewing PR in the proper order because I can only progress from there. | 12:29:07 |
| @drupol:matrix.org | * I would not advise to update hashes now or use the v2 of the builder now. | 12:31:03 |
| @drupol:matrix.org | I would advise reviewers to review one commit at a time: https://github.com/NixOS/nixpkgs/pull/312231/commits | 12:49:37 |
| 20 May 2024 |
 @genghiz:talk.go7box.xyz | Pol: I've updated the firefly-iii module and updated it to version 6.1.16. I think it's a minor enough update for it to wait until the release and then get backported. | 12:18:08 |
