14 May 2024 |
patka (new account: @patka:envs.net) | There is a very slight chance, but I'll try anyway ^^
Is anyone aware of the couchbase php sdk going closed source? We have a PHP extension for couchbase that currently doesn't build. We have 3.2.2, which is the last version on the repo. But it seems like the newest version is 4.2.1.
So I'm afraid they went closed source and we'd just have to build from the tarball. But maybe I'm missing something since I don't use couchbase?
| 17:02:07 |
Jan Tojnar | In reply to @patka_123:matrix.org
There is a very slight chance, but I'll try anyway ^^
Is anyone aware of the couchbase php sdk going closed source? We have a PHP extension for couchbase that currently doesn't build. We have 3.2.2, which is the last version on the repo. But it seems like the newest version is 4.2.1.
So I'm afraid they went closed source and we'd just have to build from the tarball. But maybe I'm missing something since I don't use couchbase?
See PR 240673 | 17:48:12 |
Jan Tojnar | * See https://github.com/NixOS/nixpkgs/pull/240673 | 17:48:58 |
Pol | good luck with that thing patka :S | 18:25:40 |
patka (new account: @patka:envs.net) | Yeah... I will spent my time and energy on happier things. It seems like this is the only thing left within nixpkgs php that is not working, so we have to leave something broken ^^ | 18:40:19 |
16 May 2024 |
Pol | I'm making plenty of experimentation at the moment with the version 2 of the PHP builder. | 12:36:57 |
Pol | * I'm making plenty of experimentations at the moment with the version 2 of the PHP builder. | 12:37:03 |
Pol | I was looking for a cleaner way to use Composer plugins. | 12:37:13 |
Pol | Had to work on this yesterday and today at work. | 12:37:23 |
Pol | I finally came up with this interface: https://github.com/NixOS/nixpkgs/pull/308059/commits/29d9c8a602875fe096eb35fc60dd1b1ece510e8d | 12:37:32 |
Pol | This works, but I don't know if it's the best way to do that. | 12:37:53 |
Pol | Feel free to hack and participate in the PR at https://github.com/NixOS/nixpkgs/pull/308059 | 12:38:06 |
Pol | Thanks to this, I can fix some bad design from version 1: https://github.com/NixOS/nixpkgs/pull/308059/commits/133d96cb6a70582d65ae8161906c4c4823457bd1 | 13:16:38 |
Pol | I will most probably split that PR in multiple PR, trying to backport the good thing before introducing the version 2. | 13:16:57 |
Pol | A lot of work ahead to avoid breaking everything. | 13:17:04 |
Pol | Any small help is very welcome. | 13:17:11 |
Pol | Here's some backport for the builder version 1: https://github.com/NixOS/nixpkgs/pull/312231 | 15:07:28 |
Pol | I think I'm done with that PR. | 16:14:42 |
Pol | I'm happy enough... until someone will make a review and will kill my modjo :D looking at you Jan Tojnar ! :D :D :D | 16:15:13 |
Pol | Redacted or Malformed Event | 16:16:52 |
17 May 2024 |
Pol | This morning I rewrote the PR https://github.com/NixOS/nixpkgs/pull/312231, the new builder look like the existing builder now, with finalAttrs override stuff. Everything works great, I'm extremelly satisfied of the result. | 08:38:46 |
Pol | Given the amount of work in this PR, I'll merge it in one week if I don't have feedback. The easiest way to review it is going commit per commit. | 08:39:17 |
patka (new account: @patka:envs.net) | I will gladly review it, but I currently don't have the bandwith. And you probably want someone more experienced as well | 09:43:04 |
Pol | No worries it's fine | 10:07:11 |
piotrkwiecinski | Hi everyone. When https://github.com/NixOS/nixpkgs/pull/308059 is ready feel free to ping me and I'm happy to help with migrating php package to v2 builder, so you can focus on more tasks. | 12:11:19 |
Pol | v2 is not going to be out "soon". | 12:13:37 |
Pol | The PR https://github.com/NixOS/nixpkgs/pull/312231 needs to comes first, then I'll rebase the PR for the V2 builder on it. | 12:13:59 |
piotrkwiecinski | I saw it as well but I'm not experienced enough to review it. I can help with reviewing PHP package updates if that helps. | 12:18:38 |
patka (new account: @patka:envs.net) | There are not many. If you want you could go through the list to find out if something needs to be updated? | 12:21:54 |
Pol | I would not advise to update hashes now. | 12:28:27 |