14 May 2024 |
Pol | good luck with that thing patka :S | 18:25:40 |
patka (new account: @patka:envs.net) | Yeah... I will spent my time and energy on happier things. It seems like this is the only thing left within nixpkgs php that is not working, so we have to leave something broken ^^ | 18:40:19 |
16 May 2024 |
Pol | I'm making plenty of experimentation at the moment with the version 2 of the PHP builder. | 12:36:57 |
Pol | * I'm making plenty of experimentations at the moment with the version 2 of the PHP builder. | 12:37:03 |
Pol | I was looking for a cleaner way to use Composer plugins. | 12:37:13 |
Pol | Had to work on this yesterday and today at work. | 12:37:23 |
Pol | I finally came up with this interface: https://github.com/NixOS/nixpkgs/pull/308059/commits/29d9c8a602875fe096eb35fc60dd1b1ece510e8d | 12:37:32 |
Pol | This works, but I don't know if it's the best way to do that. | 12:37:53 |
Pol | Feel free to hack and participate in the PR at https://github.com/NixOS/nixpkgs/pull/308059 | 12:38:06 |
Pol | Thanks to this, I can fix some bad design from version 1: https://github.com/NixOS/nixpkgs/pull/308059/commits/133d96cb6a70582d65ae8161906c4c4823457bd1 | 13:16:38 |
Pol | I will most probably split that PR in multiple PR, trying to backport the good thing before introducing the version 2. | 13:16:57 |
Pol | A lot of work ahead to avoid breaking everything. | 13:17:04 |
Pol | Any small help is very welcome. | 13:17:11 |
Pol | Here's some backport for the builder version 1: https://github.com/NixOS/nixpkgs/pull/312231 | 15:07:28 |
Pol | I think I'm done with that PR. | 16:14:42 |
Pol | I'm happy enough... until someone will make a review and will kill my modjo :D looking at you Jan Tojnar ! :D :D :D | 16:15:13 |