| 24 Apr 2022 |
 Andreas Schrägle | We normally try to avoid that to combat bit-rot. What's the patch? | 15:44:25 |
 Pol | The issue is that I cannot compile PHP 7.2 on MacOS: https://github.com/loophp/nix-shell/runs/6147454385?check_suite_focus=true | 15:45:05 |
| Pol | There is an issue with the intl extension | 15:45:14 |
| Pol | And I think I found a patch here: https://bugs.php.net/bug.php?id=76826 | 15:45:27 |
| Pol | But I cannot test locally, I need to test it on Github action. | 15:45:42 |
| Andreas Schrägle | 7.2? isn't that long dead? | 15:47:08 |
| Pol | It is dead. | 15:47:38 |
| Pol | But we are maintaining a package here fossar/nix-phps where we maintain all PHP versions. | 15:48:05 |
| Pol | And just for the sake of it, I'm trying to fix the issue. | 15:48:14 |
 hexa |
The following versions are currently supported:
| 15:48:30 |
| hexa | where supported implies something very weird. | 15:48:40 |
| Pol | We should update the README file, for sure. | 15:49:57 |
| Pol | Here's the problem with PHP 7.2: https://dpaste.org/OgXgA | 19:07:40 |
| Pol | It seems to be an issue in the intl extension. | 19:07:52 |
| Pol | I cannot figure out what's the issue. | 19:08:02 |
| Pol | The issue only happen on MacOS. | 19:08:09 |
| 25 Apr 2022 |
| Pol | etu: The pull request for adding PlatformSH has been recreated here: https://github.com/NixOS/nixpkgs/pull/170065 would be nice to have your input ! | 07:33:16 |
 etu | :) | 07:52:26 |
| etu | Yeah, it made more sense to not have it in PHP packages since it doesn't matter which PHP version it uses | 07:52:46 |
| etu | At least compared to something like composer where it matters a lot which extensions and php version it runs on | 07:53:16 |
| Pol | I agree ! | 07:53:28 |
| Pol | There are still 2 things that are really problematic in Nix with PHP. | 07:53:42 |
| Pol | And I can't do anything about it | 07:53:48 |
| Pol |
- https://github.com/NixOS/nixpkgs/pull/157287
- https://github.com/NixOS/nixpkgs/issues/154774
| 07:54:22 |
| Pol | It would be so nice to push these 2 issues. | 07:54:32 |
| Pol | The first one prevent me to use infection/infection locally. As it needs XDebug, it fails because of all the warnings. | 07:54:58 |
| Pol | The second one also need some care, but I don't know where or how to start. | 07:55:19 |
| etu | Writing a test | 07:55:30 |
| Pol | I don't really know, if you could give it some love or at least explain a bit how to do, I might have a look at some point. | 07:56:21 |
| etu | Here's the tests file for php: https://github.com/NixOS/nixpkgs/blob/master/nixos/tests/php/default.nix | 07:58:30 |
