!jngDrdMgndWibPCYsR:nixos.org

Nix PHP

74 Members
A room for PHP developers running on Nix21 Servers

Load older messages


SenderMessageTime
25 Mar 2022
@jtojnar:matrix.orgJan TojnarI would expect the pkg-config check here to fail: https://github.com/php/php-src/blob/20fe5e41629c31c8445d1df09d17b471be166774/ext/gd/config.m4#L7713:45:09
@jtojnar:matrix.orgJan Tojnaroh, apparently, it is only used for the bundled-libgd case: https://github.com/php/php-src/blob/20fe5e41629c31c8445d1df09d17b471be166774/ext/gd/config.m4#L18213:46:38
@drupol:matrix.orgPolSo, what's the battle plan in the end?14:16:59
@drupol:matrix.orgPolI think I got something working locally. Going to amend the PR14:18:09
@jtojnar:matrix.orgJan TojnarI would go with extra dependencies in package-overrides.nix14:19:03
@drupol:matrix.orgPolyep that's what I did.14:19:14
@jtojnar:matrix.orgJan Tojnarand maybe link to the gd change in commit message14:19:33
@drupol:matrix.orgPolDone.14:22:59
@drupol:matrix.orgPol#drumrolls14:23:06
@drupol:matrix.orgPolLooks like we have a winner!14:27:19
@drupol:matrix.orgPol Looks ok for you Jan Tojnar ? 14:30:58
@drupol:matrix.orgPolCommitted your change.14:33:48
@drupol:matrix.orgPolReady to be merged :)14:35:07
@drupol:matrix.orgPolDone.14:38:58
@jtojnar:matrix.orgJan Tojnarsorry, I meant squashing it even with the update commit, since that is still broken14:44:58
@jtojnar:matrix.orgJan Tojnar * sorry, I meant squashing it even with the update commit, since that one is still broken14:45:03
@drupol:matrix.orgPolOk14:45:37
@drupol:matrix.orgPoldone.14:46:42
@jtojnar:matrix.orgJan Tojnarthanks14:50:34
@drupol:matrix.orgPolThanks ! :)14:58:21
31 Mar 2022
@danielsiepmann:matrix.orgDaniel Siepmann joined the room.17:21:50
2 Apr 2022
@drupol:matrix.orgPolComposer update to review: https://github.com/NixOS/nixpkgs/pull/16694416:29:16
6 Apr 2022
@drupol:matrix.orgPolWe need some review here: https://github.com/NixOS/nixpkgs/pull/16237608:41:02
8 Apr 2022
@drupol:matrix.orgPol Rename the symfony-cli binary in symfony: PR to review here: https://github.com/NixOS/nixpkgs/pull/167837 08:29:08
@drupol:matrix.orgPol
In reply to @drupol:matrix.org
We need some review here: https://github.com/NixOS/nixpkgs/pull/162376
etu: Could you check this PR ? I think it's ready to merge, can you have a look at it?
08:29:57
@drupol:matrix.orgPolThanks mate, much appreciated.09:11:43
10 Apr 2022
@drupol:matrix.orgPol etu: Another easy one: https://github.com/NixOS/nixpkgs/pull/167837 20:14:12
12 Apr 2022
@drupol:matrix.orgPol \o/ nixpkgs-unstable is unblocked ! 19:10:09
13 Apr 2022
@drupol:matrix.orgPolPHP 7.4.29, 8.1.5 is already in a PR, awaiting for PHP 8.0.18 to remove the DRAFT status from the PR.19:28:18
@drupol:matrix.orgPolLink: https://github.com/NixOS/nixpkgs/pull/16851419:28:22

Show newer messages


Back to Room ListRoom Version: 6