| 9 Jun 2023 |
 Pol | Jan Tojnar: I've checked the fileinfo.so file and added the info in the issue. | 19:35:40 |
| Pol | TBH, I don't know what I'm looking for yet. | 19:35:51 |
 Jan Tojnar | In reply to @drupol:matrix.org
TBH, I don't know what I'm looking for yet. looks okay to me, I guess time to bisect | 19:43:30 |
| Pol | bisect... ? PHP ? | 19:43:43 |
| Pol | Curious to see how you do that | 19:44:10 |
| Jan Tojnar | you can set src of the Nix package to the path to your local php-src checkout | 19:44:59 |
| Jan Tojnar | and then run git bisect run nix-build ~/Projects/nixpkgs -A php | 19:45:25 |
| Pol | Ok | 19:45:53 |
| Pol | Going to try | 19:45:55 |
| Jan Tojnar | might need to adjust the expression a bit to allow for differences from the tarball | 19:46:30 |
| Jan Tojnar | so best try building it on the known good/bad tags first | 19:47:15 |
| Pol | So, the first commit will be the one tagged with 8.2.7 I guess. | 19:47:50 |
| Pol | Oh boy the branch management in the php project, I don't get it. | 19:49:22 |
| Pol | Feel free to take care of it I don't know if I will be able to do it. | 20:30:00 |
| Jan Tojnar | I think I will leave it to PHP maintainers, still have bunch of GNOME libraries I need to update 😆 | 20:40:45 |
| 12 Jun 2023 |
 etu | By the time we drop 8.0 we should probably move to 8.2 as default as well 🙂 | 09:02:51 |
| Pol | Is there someone who can review this commit and let me know if it's ok? Basically, this is a composer plugin: https://github.com/NixOS/nixpkgs/pull/225401/commits/8b034b8edc879c62eab285c46256c47bb05a72f7 | 16:38:10 |
| Pol | * Is there someone who can review this commit and let me know if it's ok? Basically, this is a composer plugin: https://github.com/NixOS/nixpkgs/pull/225401/commits/858868a383ea9c071e69f99e9e10c3793547d381 | 16:42:53 |
| Pol | * Is there someone who can review this commit and let me know if it's ok? Basically, this is a composer plugin: https://github.com/NixOS/nixpkgs/pull/225401/commits/cfce10ee2d809f9ab80469be79bff1253dcedd66 | 16:58:28 |
| Pol | (link updated) | 17:02:22 |
 tgerbet | In reply to @drupol:matrix.org
Is there someone who can review this commit and let me know if it's ok? Basically, this is a composer plugin: https://github.com/NixOS/nixpkgs/pull/225401/commits/cfce10ee2d809f9ab80469be79bff1253dcedd66 Maybe it would be best to retrieve the keys directly from the repository https://github.com/composer/composer.github.io
This way we are sure they do not suddenly change.
Do you need them at all? From my understanding those keys are only useful to verify the installer which we does not seem to be the case here
| 17:13:06 |
| Pol | Good idea with the Github repo. Going to do it. | 17:26:03 |
| Pol | Keys are required to avoid this: | 17:26:08 |
| Pol | 
Download image.png | 17:26:56 |
| Pol | On the top you have the version without it, on the bottom you have the version with it. | 17:27:04 |
| tgerbet | Oh okay, I did not know it was looking for that. Maybe it should be done directly in phpPackages.composer as it seems to also have the problem. It is probably not specific to your plugin | 17:32:35 |
| Pol | True, but I have no clue on how to integrate that. | 17:33:41 |
| Pol | Do you think adding a composerHome input to composer derivation is a good idea? | 17:34:01 |
| Pol | I just pushed the changes for the composer keys ! https://github.com/NixOS/nixpkgs/pull/225401/commits/9e1540b6f6f7055af9710aa1c8c83b9966953cce | 17:34:24 |
| tgerbet | In reply to @drupol:matrix.org
Do you think adding a composerHome input to composer derivation is a good idea? Probably not, it will break too many things (e.g. access to GH OAuth access token) | 17:38:55 |
