| 24 Apr 2023 |
Pol | Here's the derivation: | 18:33:15 |
Pol | { lib, fetchFromGitHub, php }:
php.buildComposerProject (finalAttrs: {
pname = "psalm";
version = "5.9.0";
src = fetchFromGitHub {
owner = "vimeo";
repo = "psalm";
rev = finalAttrs.version;
hash = "sha256-yoDJPBoRaKGd78sJoQj26T3+x2QxbHAbH/lnbTJcnIM=";
};
# TODO: Open a PR against https://github.com/sebastianbergmann/phpunit
# Missing `composer.lock` from the repository.
composerLock = ./composer.lock;
vendorHash = "";
})
| 18:33:34 |
Pol | It's failing during the composerSetupBuildHook | 18:33:51 |
Pol |  Download image.png | 18:34:19 |
Pol | I just cannot find the reason why it's failing. | 18:34:30 |
Pol | When I clone the project locally, this is working fine. | 18:34:38 |
Jan Tojnar | Pol: 1.0.0+no-version-set looks suspicious | 19:02:55 |
Pol | Yes, can't understand where it comes from | 19:20:09 |
Pol | From composer that's sure, but why ?! | 19:22:51 |
Pol | Found the issue. | 19:59:18 |
Pol | COMPOSER_ROOT_VERSION="${version}" \ | 20:03:59 |
Pol | https://github.com/NixOS/nixpkgs/blob/5ab2b1e0e1d9c3483371c93d20c08ecc1d1c4b5a/pkgs/development/php-packages/psalm/default.nix | 20:09:21 |
Pol | Now it's fixed. | 20:09:25 |
Pol | Amount of PHAR based software in Nix now: 1 (Composer) | 20:17:29 |
Pol | and we're back to green. | 20:37:39 |
Pol | Redacted or Malformed Event | 20:49:05 |
Pol | Redacted or Malformed Event | 20:50:47 |
Pol | Redacted or Malformed Event | 20:50:50 |
| 25 Apr 2023 |
Pol | Jan Tojnar: Anything else to do for the PHP Builder branch? | 08:20:20 |
Jan Tojnar | Pol: nothing comes to mind | 15:16:04 |
Pol | Good news :D | 15:17:40 |
tgerbet | I made a few comments on the PR, sorry for being late to the party 🫤 | 17:41:34 |
Pol | COMPOSER_HTACCESS_PROTECT WHaaaaaat ?! | 17:43:23 |
Pol | tgerbet: Got an even better idea while reading your comments. | 18:07:13 |
tgerbet | Great! Because to be honest I was not really a big fan of mine | 18:08:45 |
Pol |  Download image.png | 18:09:15 |
Pol | WDYT of that? | 18:09:18 |
Pol | Basically, I merge 2 composer.json files together to override. | 18:09:34 |
Pol | I think it's cleaner to do that. | 18:09:45 |
tgerbet | Yep indeed, it's more readable 👍️ | 18:10:45 |