| 15 Apr 2023 |
 Jan Tojnar | though docs will also be needed | 20:52:40 |
 Pol | I will document at the very end | 20:53:02 |
| Pol | Jan Tojnar tgerbet Would it be a good idea to download the file composer.lock instead of having it in the repo ? | 21:49:43 |
 tgerbet | If it is available in the upstream source repository yeah it's likely better to re-use it (if that's the question, I did not follow the progress on your PR been a bit busy these last days) | 21:51:58 |
| Pol | yes that's what I'm suggesting, to download it from the upstream repo. | 22:01:06 |
| Pol | Since fetchFromGitHub is stripping some files based on .gitattributes. | 22:01:25 |
| Pol | What would you recommend to download the composer.lock file ? wget or a fetcher? | 22:01:48 |
| Pol | I guess using a fetcher is a better solution? | 22:01:58 |
| Pol | Definitely a fetcher. | 22:18:34 |
| Pol | `fetchurl` is good enough | 22:19:17 |
| Pol | Tomorrow I'll update the pr | 22:19:28 |
| Jan Tojnar | you can pass useFetchGit to fetchFromGitHub in those cases. | 22:25:55 |
| tgerbet | It seems from the diverse tools you have modified on Phing is concerned | 22:31:33 |
| Pol | Ahhh nice, thanks:) | 22:31:39 |
| tgerbet | * It seems from the diverse tools you have modified only Phing is concerned | 22:31:40 |
| Pol | In reply to @tgerbet:matrix.org
It seems from the diverse tools you have modified only Phing is concerned There are more where I need to provide composer.lock | 22:32:11 |
| Pol | I'll check tomorrow | 22:32:23 |
| tgerbet | Yep but a lot of them do not provide a composer.lock at all | 22:32:32 |
| Pol | Yeah true as well. | 22:32:49 |
| tgerbet | The only exception besides Phing in the list seems to be deployerphp/deploy but it seems it is only because the composer.lock was not removed from a previous iterations | 22:33:55 |
| Pol | Ah oops ! | 22:34:35 |
| Pol | I'll fix this | 22:34:54 |
| tgerbet | * The only exception besides Phing in the list seems to be deployerphp/deploy but it seems it is only because the composer.lock was not removed from a previous iteration | 22:35:04 |
| Pol | Nice catch though | 22:36:42 |
| 16 Apr 2023 |
| Pol | In reply to @tgerbet:matrix.org
The only exception besides Phing in the list seems to be deployerphp/deploy but it seems it is only because the composer.lock was not removed from a previous iteration Job done. | 09:11:36 |
| Pol | In reply to @jtojnar:matrix.org
buildPhpProject would basically become stdenv.mkDerivation wrapper with composerSetupHook in nativeBuildInputs and setting composerDeps to the result of buildComposerVendorDir function, which the setup hook would then use So, the idea is to create a function for building only the vendor dir ? | 09:13:00 |
| Jan Tojnar | Pol: yup, so that it can also be used when buildPhpPackage cannot be used | 15:19:06 |
| Pol | Ok. Will do. | 15:36:26 |
| Pol | But that function will only do the `composer --download-only` then ? | 15:41:06 |
| Jan Tojnar | yup | 15:47:42 |
