| 11 Apr 2023 |
Pol | Nope, big nope. | 17:16:25 |
Pol | Even if I remove buildPecl from that list, it's still available when I do php.buildPecl ! | 17:16:42 |
Pol | Jan Tojnar: Are you totally against adding the flag sessionSupport ? Wouldn't it be a good idea to add a flag for each configuration flag at some point in the future? | 17:22:56 |
Pol | Argh you just replied | 17:23:00 |
Pol | Reading. | 17:23:02 |
Pol | Closed the issue, thx for your input | 17:23:29 |
Jan Tojnar | not really against, I just think the cost is 0.1 and the benefit 0.05 | 17:24:39 |
Pol | Ok it's fine, I was just proposing | 17:24:54 |
Pol | It would have been cleaner in my flake.nix to have it as a flag :) | 17:25:13 |
Jan Tojnar | yeah, I am weighting the benefit by the amount of use the flag would get | 17:26:05 |
Pol | Yeah but that use flag would have been defaulted to true so it would not have been a burden | 17:26:32 |
Jan Tojnar | and I do not expect it would be very high, so the cleanliness of Nixpkgs wins out in my calculus | 17:26:38 |
Jan Tojnar | the generic.nix would still expand | 17:26:55 |
Pol | mmmh | 17:27:21 |
Pol | Do you have a clue for the other issue I'm facing with buildPHPproject ? It's a real mistery for me | 17:27:49 |
Jan Tojnar | it works for me here | 17:31:13 |
Jan Tojnar | https://gist.github.com/jtojnar/1474b065e964e4f19aaa0eb54edb6ae1 | 17:32:03 |
Pol | wtf :( | 17:32:05 |
Pol | Trying again. | 17:32:25 |
Jan Tojnar | by the way, probably should use buildPhpProject capitalization to be consistent with other code | 17:34:57 |
Pol | Oki will do. | 17:35:12 |
Pol | going to dedicate an hour after kds are done here :) | 17:35:25 |
Pol | Jan Tojnar: Should I use finalAttrs within buildPhpProject ? | 19:39:50 |
Jan Tojnar | Pol: the important part is supporting passing function as an argument to buildPhpProject | 20:05:11 |
Jan Tojnar | so that the projects can continue doing that like grumphp did | 20:05:40 |
Pol | I will try. | 20:16:48 |
Pol | I almost got rid of most of .phar based derivation. | 20:17:19 |
Pol | * I almost got rid of most of .phar based derivations. | 20:18:06 |
Pol | remains psalm, drush and deployer. | 20:18:32 |
Pol | But I can't do it | 20:18:55 |