| 9 Apr 2023 |
 Pol | * Here's what I succeeded to do in 30 min, with the grumphp derivation as example:
{ buildPHPproject, fetchFromGitHub, lib, php }:
buildPHPproject rec {
inherit php;
pname = "grumphp";
version = "1.15.0";
src = fetchFromGitHub {
owner = "phpro";
repo = "grumphp";
rev = "v${version}";
hash = "sha256-EIGIoImRKR1Mc7oFXIzuLD3S1zx9WtHwDX0ST1T4BH0=";
};
vendorOutputHash = "sha256-TGGwRh7NSBKqt43GpmS7zY6togyEkEk/6wf2ys18OF8=";
postInstall = ''
ln -s $out/share/php/${pname}/bin/${pname} $out/bin/${pname}
'';
}
| 09:46:52 |
| Pol | * Here's what I succeeded to do in 30 min, with the grumphp derivation as example:
{ buildPHPproject, fetchFromGitHub, lib }:
buildPHPproject rec {
pname = "grumphp";
version = "1.15.0";
src = fetchFromGitHub {
owner = "phpro";
repo = "grumphp";
rev = "v${version}";
hash = "sha256-EIGIoImRKR1Mc7oFXIzuLD3S1zx9WtHwDX0ST1T4BH0=";
};
vendorOutputHash = "sha256-TGGwRh7NSBKqt43GpmS7zY6togyEkEk/6wf2ys18OF8=";
postInstall = ''
cd $out
ln -s $out/share/php/${pname}/bin/${pname} $out/bin/${pname}
'';
meta = with lib; {
changelog = "https://github.com/phpro/grumphp/releases/tag/v${version}";
description = "A PHP code-quality tool";
homepage = "https://github.com/phpro/grumphp";
license = licenses.mit;
maintainers = teams.php.members;
};
}
| 09:49:48 |
| Pol | I pushed my draft here: https://github.com/NixOS/nixpkgs/pull/225401 | 09:58:06 |
| Pol | My Easter sunday starts very well :D | 09:59:46 |
| Pol | I'm pretty sure the excitement will drop down after some reviews anyway :D | 10:00:02 |
| Pol invited  @shyim-5532ae2f15522ed4b3df33d3:gitter.im. | 17:47:02 |
|  Shyim joined the room. | 17:47:49 |
| Pol | Jan Tojnar: I tried the finalAttrs: pattern... but I can't get it to work. | 19:06:45 |
| Pol | Redacted or Malformed Event | 19:10:32 |
| Pol | Jan Tojnar: I can't use the builder outside of the PHP packages scope... example, how can I use buildPHPproject for PHPActor ? (https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/tools/phpactor/default.nix) | 19:17:36 |
| Pol | When I try to add it in the first line, I get: | 19:17:53 |
| Pol | error: evaluation aborted with the following error message: 'Function called without required argument "buildPHPproject" at /nix/store/qa7zxpw9g2qixsqblaga7hsasqhs65kb-source/pkgs/development/tools/phpactor/default.nix:1' | 19:18:24 |
| 10 Apr 2023 |
 Jan Tojnar | Pol: it is defined inside php.packages scope | 09:20:49 |
| Jan Tojnar | not top-level | 09:20:57 |
| Pol | How should I call this for phpactor which is out of the php.packages scope then ? | 09:33:23 |
| Jan Tojnar | take php as argument to the package and use php.packages.buildPhpProject | 09:34:58 |
| 11 Apr 2023 |
| Pol | Jan Tojnar: I tried, doesn't work at all. I don't know what's the problem | 07:06:51 |
| Pol | 
Download image.png | 07:17:43 |
| Pol | And the source: | 07:18:22 |
| Pol | { fetchFromGitHub php }:
php.packages.buildPHPproject rec {
pname = "phpactor";
version = "2023.01.21";
src = fetchFromGitHub {
owner = "phpactor";
repo = "phpactor";
rev = version;
hash = "sha256-jWZgBEaffjQ5wCStSEe+eIi7BJt6XAQFEjmq5wvW5V8=";
};
}
| 07:18:28 |
| Pol | * { fetchFromGitHub, php }:
php.packages.buildPHPproject rec {
pname = "phpactor";
version = "2023.01.21";
src = fetchFromGitHub {
owner = "phpactor";
repo = "phpactor";
rev = version;
hash = "sha256-jWZgBEaffjQ5wCStSEe+eIi7BJt6XAQFEjmq5wvW5V8=";
};
}
| 07:18:38 |
| Pol | 
Download image.png | 07:51:03 |
| Pol | I just don't understand. How come that buildPecl is available, while buildPHPproject is not ? | 07:51:24 |
| Pol | I also created a PR to be able to disable session support in PHP derivation at: https://github.com/NixOS/nixpkgs/pull/225709 | 08:45:40 |
| Pol | For which I'm looking for review :) | 08:52:59 |
| Pol | And if you're wondering why I need this PR is to show my colleagues that the version of PHP I use doesnt have support for Session and I can still do persistent storage in my app. | 10:23:04 |
| Jan Tojnar | Pol: https://github.com/NixOS/nixpkgs/blob/2dfbb7c8891da0429caa8c0d198570bd58d0f9be/pkgs/development/interpreters/php/generic.nix#L162-L163 | 16:13:20 |
| Pol | checking | 17:10:37 |
| Pol | In reply to @jtojnar:matrix.org
Pol: https://github.com/NixOS/nixpkgs/blob/2dfbb7c8891da0429caa8c0d198570bd58d0f9be/pkgs/development/interpreters/php/generic.nix#L162-L163 I tried to add it in that list, same result... | 17:10:58 |
| Pol | I'll try again now. | 17:11:01 |
