Nix PHP | 74 Members | |
| A room for PHP developers running on Nix | 21 Servers |
| Sender | Message | Time |
|---|---|---|
| 23 Mar 2023 | ||
In reply to @drupol:matrix.orgIf you ask me, yes. Discussed the issue off band with Jan and he was also fine | 12:55:48 | |
| yep, it was merely to let other maintainers know about the PR :) | 13:04:02 | |
| I'm also ok to merge it | 13:04:07 | |
| 27 Mar 2023 | ||
| PHPBench, init at 1.2.10 : https://github.com/NixOS/nixpkgs/pull/223365 Ready for review! | 09:27:44 | |
| 28 Mar 2023 | ||
| ^^ | 06:21:33 | |
| I know PHP 7.4 is deprecated but PHPBench is still supporting it, is it on purpose you decided to directly use PHP 8.0 ? | 07:40:48 | |
| We don't have php74 in nixpkgs | 08:05:52 | |
| The reason we drop it right after the XX.11 release is that it gives time to figure out everything that breaks of the removal before the XX.05 release 🙂 | 08:07:06 | |
| Then we also bump the default PHP used right after the XX.05 release to figure out what breaks before the XX.11 release 🙂 | 08:08:47 | |
| Also PHP 7.4 isn't just deprecated. It's eol. What is deprecated is php 8.0 | 08:13:33 | |
| So PHP 8.0 will be dropped May or so just to find breaking points. :) | 08:15:21 | |
| * The reason we drop it right after the XX.05 release is that it gives time to figure out everything that breaks of the removal before the XX.11 release 🙂 | 08:15:36 | |
| What's wrong with what I did ? | 09:07:49 | |
I actually think that it would be better to use php in the function header and then set the version in callPackage is a better way to do it. Also I wouldn't overwrite the php version away from the global default in nixpkgs (php81) unless there is a specific reason to do it. | 09:14:57 | |
| I put my remarks in the nixpkgs pr where they belong... | 09:17:11 | |
| Nice, very good idea. | 09:37:25 | |
I also replicated that in n98-magerun | 09:37:33 | |
| The commit is also inside that PR, I guess it's not an issue. | 09:37:46 | |
| https://github.com/NixOS/nixpkgs/pull/223365 | 09:37:49 | |
| Pol: there is nothing wrong, etu kind of headed where I wanted to but I wasn't enough explicit! | 09:57:32 | |
| oki | 09:58:28 | |
| philipp: Feel free to let me know if it's better now | 13:29:29 | |
| 29 Mar 2023 | ||
| Hey PHPers, Do you think we can do something similar but for PHP ? | 07:18:42 | |
| * Hey PHPers, Do you think we can do something similar but for PHP ? | 07:21:45 | |
| * Hey PHPers, Do you think we can do something similar but for PHP ? This is the file handling the import of the | 07:23:31 | |
| https://github.com/NixOS/nixpkgs/blob/nixos-22.11/pkgs/tools/networking/rustcat/default.nix This is an example of usage of this, right? What I really don't like about this method is that it completely hides all dependencies from the rest of the system. | 07:32:25 | |
| AFAIU Pol was specifically talking about the approach where you import the Cargo.lock rather than using a FOD and this method doesn't have this flaw, correct? | 07:35:28 | |
| Oh, that would be cool. | 07:35:51 | |
| Is there an example of it's usage in nixpkgs somewhere? | 07:37:59 | |
| Regarding the original question: without having taken a close look I think that this should be possible and I'd really like it (especially because I could get rid of at least one occurrence of composer2nix in my employer's deployment I guess). | 07:38:43 | |