| 19 Mar 2023 |
 Pol | It's cool to build PHP just with some attributes and text | 22:15:28 |
 Lars Strojny | I was hesitating to use composer support as it implies impure flakes. I am wondering though if one could make the flakes pure by relying on composer.lock content-hash. Not sure if that’s at all feasible but it should be safe | 22:16:05 |
| Pol | By the way, the first argument of makePhp is system, not pkgs | 22:16:39 |
| Lars Strojny | See how great my nix skills are :) | 22:17:07 |
| Pol | In reply to @lstrojny:matrix.org
I was hesitating to use composer support as it implies impure flakes. I am wondering though if one could make the flakes pure by relying on composer.lock content-hash. Not sure if that’s at all feasible but it should be safe That is possible but it's more complicated. | 22:17:13 |
| Pol | In reply to @drupol:matrix.org
That is possible but it's more complicated. There is this : https://github.com/drupol/composer-plugin-nixify | 22:18:53 |
| Pol | Heading to bed now | 22:19:32 |
| Pol | See you tomorrow | 22:19:42 |
| Lars Strojny | See you!
| 22:19:53 |
| Lars Strojny | Btw, changing pkgs to system gives me that | 22:20:01 |
| Lars Strojny |
at /nix/store/s8427y5ln38zyyya2vgh3hfk0cq414mi-source/src/phps.nix:113:12:
112| if builtins.isString php
113| then pkgs."${php}"
| ^
114| else php;```
| 22:20:05 |
| Pol | `nix flake update` :) | 22:20:25 |
| Lars Strojny | :-D | 22:20:40 |
| 20 Mar 2023 |
| Pol | Lars Strojny: I just submitted a PR to refactor your flake.nix: https://github.com/lstrojny/uffff/pull/11 | 07:36:40 |
| Pol | It's purely informative and it's totally fine to reject it :) | 07:36:57 |
| Pol | Ok since ryantm-bot is not working for PHP and Composer, I created the PR: https://github.com/NixOS/nixpkgs/pull/222253 | 21:36:35 |
| Pol | Please have a look on it :) | 21:36:51 |
| Pol | Have a good night | 21:36:54 |
| 21 Mar 2023 |
| Pol | Job done etu https://github.com/NixOS/nixpkgs/pull/222313 | 08:04:57 |
| Pol | A PHP related PR: https://github.com/NixOS/nixpkgs/pull/221985 | 12:42:41 |
| Lars Strojny | In reply to @drupol:matrix.org
Lars Strojny: I just submitted a PR to refactor your flake.nix: https://github.com/lstrojny/uffff/pull/11 Btw: needed to revise it slightly again so that the fork is used as an input: https://github.com/lstrojny/uffff/commit/05046778c1285f9b4cd9793f76be9824e196fe77 | 19:36:38 |
| Pol | sure sure :) | 19:37:08 |
| Pol | Don't forget to run nix fmt at the end :) | 19:37:16 |
| Lars Strojny | my vim setup does that for me | 19:40:36 |
| Lars Strojny | Just that I have a wider line width configured | 19:40:44 |
| Pol | Ok you already have a formatter then | 19:43:35 |
| Pol | Oooh you changed to nixfmt | 19:44:08 |
| Pol | I missed that | 19:44:10 |
| Pol | All good then :) | 19:44:13 |
| 23 Mar 2023 |
| Pol | Are you ok to merge this? https://github.com/NixOS/nixpkgs/pull/221845 | 07:53:20 |
