| 15 Apr 2022 |
 hexa | but I'd be wary of backporting too many feature bumps π | 13:03:56 |
 Pol | hexa: for backporting, the branch is release-21.11? | 13:09:03 |
| hexa | yep | 13:09:13 |
| hexa | if you've never backported anything, check out the section in the contribution documentation | 13:09:51 |
| Pol | ok | 13:10:01 |
| Pol | Backport: https://github.com/NixOS/nixpkgs/pull/168785 | 13:13:08 |
| hexa | so you're kinda saying these commits never happend there:
3aa6277c43b php74Packages.composer: 2.2.9 -> 2.3.3
8bf228ce2a4 php74Packages.composer: 2.2.7 -> 2.2.9
d118f55e231 php74Packages.composer: 2.2.6 -> 2.2.7
2b225076c7d php74Packages.composer: 2.2.3 -> 2.2.6
cb9f7cafde3 php74Packages.composer: 2.2.1 -> 2.2.3
5c6e813ba3e php74Packages.composer: 2.1.14 -> 2.2.1
0782984c059 php74Packages.composer: 2.1.9 -> 2.1.14 | 13:15:43 |
| hexa | also what about breaking changes in these versions? | 13:16:18 |
| Pol | There are none | 13:18:25 |
| Pol | There are breacking changes, but for the plugin API "in" php. | 13:18:58 |
| Pol | It won't impact users. | 13:19:03 |
| hexa | fair, still need to pick up all individual commits there π | 13:20:11 |
| hexa | * fair, still need to pick up all individual commits there instead of mangling your own π | 13:20:31 |
| Pol | Really? | 13:21:33 |
| Pol | So, the backport I did is not good? | 13:22:02 |
| Pol | I need to replay(cherry-pick) all commits from unstable? | 13:22:28 |
 Andreas SchrΓ€gle | cherry-pick -x preferably. So it's trivial to cross reference if something came from master or needed to be created specifically for a release branch, which is something we are trying to avoid. | 13:24:54 |
| Pol | Ok I understand. | 13:26:48 |
| Pol | Will do that. | 13:26:50 |
| Pol | Can I do that in one single PR ? | 13:27:01 |
| hexa | yep | 13:29:38 |
| Pol | Job done. | 13:31:43 |
| hexa | looks good, I'll let the php team do the review though π | 13:32:38 |
| Pol | Thanks for the help! | 13:33:44 |
|  Christian Albrecht joined the room. | 16:18:10 |
| Christian Albrecht | hello folks π | 16:18:38 |
| Christian Albrecht | ma27 send me here, because i bothered him about a failing php build on my machine. (I silenced it by disabling the failing test, so no worries for me ;)) Just to give you a heads up notice in case you are interested...
alab /ws/nixpkgs ξ master (a7cf937) took 1m58s
% nix-shell -I nixpkgs=/ws/nixpkgs -p 'php.withExtensions ({ fileinfo }: [ fileinfo ])'
is failing with
=====================================================================
TEST RESULT SUMMARY
---------------------------------------------------------------------
Exts skipped : 0
Exts tested : 12
---------------------------------------------------------------------
Number of tests : 52 47
Tests skipped : 5 ( 9.6%) --------
Tests warned : 0 ( 0.0%) ( 0.0%)
Tests failed : 1 ( 1.9%) ( 2.1%)
Tests passed : 46 ( 88.5%) ( 97.9%)
---------------------------------------------------------------------
Time taken : 1 seconds
=====================================================================
=====================================================================
FAILED TEST SUMMARY
---------------------------------------------------------------------
Bug #68996 (Invalid free of CG(interned_empty_string)) [tests/bug68996.phpt]
=====================================================================
You may have found a problem in PHP.
This report can be automatically sent to the PHP QA team at
http://qa.php.net/reports and http://news.php.net/php.qa.reports
This gives us a better understanding of PHP's behavior.
If you don't want to send the report immediately you can choose
option "s" to save it. You can then email it to qa-reports@lists.php.net later.
Do you want to send this report now? [Yns]:
Please enter your email address.
(Your address will be mangled so that it will not go out on any
mailinglist in plain text):
Warning: fsockopen(): php_network_getaddresses: getaddrinfo failed: Temporary failure in name resolution in /build/php-8.0.18/ext/fileinfo/run-tests.php on line 1152
Warning: fsockopen(): Unable to connect to qa.php.net:80 (php_network_getaddresses: getaddrinfo failed: Temporary failure in name resolution) in /build/php-8.0.18/ext/fileinfo/run-tests.php on line 1152
The test script was unable to automatically send the report to PHP's QA Team
Please send /build/php-8.0.18/ext/fileinfo/php_test_results_20220415_1558.txt to qa-reports@lists.php.net manually, thank you.
make: *** [Makefile:131: test] Error 1
error: builder for '/nix/store/i8bx7mhkz4aiggcy3r62l32k543gfhgx-php-fileinfo-8.0.18.drv' failed with exit code 2;
last 10 log lines:
> Please enter your email address.
> (Your address will be mangled so that it will not go out on any
> mailinglist in plain text):
> Warning: fsockopen(): php_network_getaddresses: getaddrinfo failed: Temporary failure in name resolution in /build/php-8.0.18/ext/fileinfo/run-tests.php on line 1152
>
> Warning: fsockopen(): Unable to connect to qa.php.net:80 (php_network_getaddresses: getaddrinfo failed: Temporary failure in name resolution) in /build/php-8.0.18/ext/fileinfo/run-tests.php on line 1152
>
> The test script was unable to automatically send the report to PHP's QA Team
> Please send /build/php-8.0.18/ext/fileinfo/php_test_results_20220415_1558.txt to qa-reports@lists.php.net manually, thank you.
> make: *** [Makefile:131: test] Error 1
For full logs, run 'nix log /nix/store/i8bx7mhkz4aiggcy3r62l32k543gfhgx-php-fileinfo-8.0.18.drv'.
error: 1 dependencies of derivation '/nix/store/5slqm7ls3kay78d2gmsjyvxbia37xylg-php-extra-init-8.0.18.ini.drv' failed to build
error: 1 dependencies of derivation '/nix/store/11s7w77n3f07nagnfzlvyjpk61j2p2l2-php-with-extensions-8.0.18.drv' failed to bu
| 16:27:18 |
| 16 Apr 2022 |
|  Lars Strojny joined the room. | 16:18:07 |
| Lars Strojny set a profile picture. | 16:28:18 |
| 19 Apr 2022 |
| Pol | Hi mate, which platform is this? | 07:24:01 |
