| 5 May 2024 |
Jan Tojnar |
- it would be confusing if you added that and e.g.
composerNoDev – which should take precedence, especially with multiple levels of overrides
- you would have to filter it out of arguments passed to
mkDerivation since attribute sets are not allowed, but then it would disappear from the fix point (maybe it would work in passthru, not sure)
| 15:10:09 |
Jan Tojnar | other builders did not really bother to support or predated the finalAttrs pattern, buildComposerProject is unique here | 15:11:24 |
Pol | Yeah I noticed :S | 15:11:39 |
Pol | hence, the added complexity to override some stuff | 15:11:49 |
Jan Tojnar | well, there is no shame in leaving advanced use cases to explicit mkComposerRepository | 15:13:11 |
Pol | I will see the things to do to override the preBuild step. | 15:13:56 |
Jan Tojnar | btw, might be a good idea to clone the old infrastructure first and then apply the changes in a new commit so the differences are easier to review. Also maybe use 2 suffix instead of Next so that further evolution has space to grow into | 15:14:56 |
Pol | Okidocky | 15:16:26 |
Pol | Have you seen, that version get rid of the composer plugin :) | 15:19:47 |
Jan Tojnar | I was to lazy to diff it against the old one, hence the request for a separate commit :) | 15:25:14 |
Pol | Done now: https://github.com/NixOS/nixpkgs/pull/308059 | 15:52:15 |
Pol | Hope it's what you're expecting | 15:52:21 |
Pol | I'll continue working on this in the upcoming days to relax | 15:55:12 |
| 6 May 2024 |
| @patka_123:matrix.org joined the room. | 15:46:02 |
Pol | Paving the way for the next version of the builder by reorganizing files of the version 1 of the builder: https://github.com/NixOS/nixpkgs/pull/309605 | 17:10:27 |
Pol | This PR doesn't change anything in the way the current builder works. It just reorganize files, nothing else, nothing more. | 17:11:47 |
| @nick_kadutskyi:matrix.org changed their display name from nick_kadutskyi to nickkadutskyi. | 17:33:23 |
| @nick_kadutskyi:matrix.org left the room. | 17:35:36 |
| Nick Kadutskyi joined the room. | 17:38:32 |
| Nick Kadutskyi changed their display name from nickkadutskyi to Nick Kadutskyi. | 17:39:34 |
piotrkwiecinski | Hello everyone. I'm quite new to nix. I'm trying to figure out a good approach to setting up multiple php projects with nginx and db running at the same time on local env. Would you point me in the right direction? Is https://devenv.sh/getting-started/ good starting point? | 18:29:06 |
Pol | Yes, Devenv is a very good starting point. Maybe Shyim can help, he's using it every day I think. | 20:58:33 |
Shyim | Is caddy also fine? | 21:52:55 |
| 7 May 2024 |
piotrkwiecinski | I'm going to need nginx to be closer to production configuration. I'll try to configure as much as I can myself and ping you if I'm stuck if you don't mind. | 06:57:42 |
Pol | Jan Tojnar: Looks like it works! https://github.com/NixOS/nixpkgs/pull/309605 | 11:09:29 |
| 8 May 2024 |
Pol | Just FYI, a new version of the builder is up at https://github.com/NixOS/nixpkgs/pull/308059 Reviews and tests are welcome. News in it:
- No more
composer-local-repo-plugin for Composer
- Performance! (it's ~twice faster)
- Simplified workflow
| 12:08:00 |
| 9 May 2024 |
piotrkwiecinski | When the new builder is ready I can migrate n98-magerun2 for start. I use it daily. I'm relatively new to nix but I'm happy to help as much as I can. | 07:56:18 |
@patka_123:matrix.org | Redacted or Malformed Event | 08:56:46 |
@patka_123:matrix.org | * buildsupport/php: add passthru.updateScript
Lets make sure that (almost) all PHP packages can be updated by the r-ryantm bot! PHP packages where upstream provides a lock file can be automatically updated with the standard updateScript. The next step (in a following PR) will be to create a script that optionally updates and replaces the local lock file if upstream doesn't provide it.
| 09:00:21 |
@patka_123:matrix.org | * buildsupport/php: add passthru.updateScript
Lets make sure that (almost) all PHP packages can be updated by the r-ryantm bot!
PHP packages where upstream provides a lock file can be automatically updated with the standard updateScript. The next step (in a following PR) will be to create a script that optionally updates and replaces the local lock file if upstream doesn't provide it.
| 09:00:33 |