| 19 May 2023 |
 Pol | Especially when cloning PHPStan | 15:36:02 |
 Jan Tojnar | that's because PHPStan is abusing git, storing binary phars there, the repo has ~1.3 GB | 15:42:22 |
| Jan Tojnar | and we cannot really use shallow fetching since that would not work with revs that are not refs (e.g. the deployer) | 15:43:37 |
| Jan Tojnar | I guess the best bet would be an iterative deepening search | 15:44:18 |
 tgerbet | Maybe use and unpack the dist tarballs when they are available and fallback to git only when they are not?
It could help with shenanigans like this one without going too deep in git/SCM stuff | 15:54:24 |
| Jan Tojnar | the issue with dist tarballs is that they lack some files (IIRC some projects were excluding lockfiles in .gitattibutes) | 15:58:11 |
| Jan Tojnar | actually, does the repo plug-in fetch source tarballs? | 15:59:01 |
| Jan Tojnar | * Pol: actually, does the repo plug-in store source or dist tarballs? | 15:59:26 |
| tgerbet | Lockfiles should not be needed in the dist tarballs, only the top level needs it and it is fetched via the usual fetchFromGithub or similar | 16:06:55 |
| Jan Tojnar | hmm, maybe I misremembered then | 16:11:53 |
| Jan Tojnar | but IIRC we switched to source tarballs for some reason | 16:12:11 |
| Jan Tojnar | maybe it was missing tests? | 16:12:19 |
| Pol | In reply to @jtojnar:matrix.org
Pol: actually, does the repo plug-in store source or dist tarballs? src | 16:14:12 |
| tgerbet | Yeah tests in the dependencies might be missing but I'm not sure it's really an issue because you also do not want to install the dev deps of the dependencies | 16:14:39 |
| tgerbet | So tests of your dependencies are likely to fail | 16:15:12 |
| Pol | #goHangHimself | 16:15:35 |
| Jan Tojnar | Pol: looks like the relative paths do not work 🙈
see nix build -L --keep-failed --no-write-lock-file ./tests#non-head-rev in https://github.com/fossar/composition-c4/pull/3 | 20:27:22 |
| Pol | Argh :S | 20:27:53 |
| Pol | What are we going to do with this thing? | 20:28:06 |
| Jan Tojnar | I am leaning towards patching composer | 20:28:34 |
| Jan Tojnar | https://github.com/composer/composer/blob/6111ff5cda367d345bf2cf99b8ca95b56fc7459e/src/Composer/Downloader/PathDownloader.php#L46 | 20:28:35 |
| Pol | Checking | 20:29:32 |
| Pol | Do you think this would fix everything? | 20:29:52 |
| Jan Tojnar | not everything but at least this thing | 20:30:06 |
| Pol | mmh mmh | 20:30:29 |
| Pol | Ok | 20:30:31 |
| Pol | Curious to see how you're going to patch it. | 20:30:51 |
| Jan Tojnar | I was thinking resolving the path relative to repository path | 20:31:03 |
| Jan Tojnar | but thinking about it more, it does not really make much sense since the repository does not have to be a path, does it? | 20:31:31 |
| Pol | There could be different type of repos indeed | 20:32:26 |
