| 12 Apr 2023 |
Pol | tgerbet: Thanks for those valuable feedback | 07:37:20 |
Jan Tojnar | Pol: you can check https://github.com/NixOS/nixpkgs/pull/194475 for the finalAttrs support | 17:06:16 |
Pol | Checking now. | 23:25:50 |
Pol | Ok finalAttrs pattern is done! :) | 23:57:11 |
| 13 Apr 2023 |
Jan Tojnar | Pol: I would still drop the [[ -e "${composerLock}" ]] | 18:21:19 |
Pol | Righty | 18:21:26 |
Pol | I though it was a good idea to have it | 18:21:40 |
Jan Tojnar | otherwise it will silently fall back to the lock file from src | 18:21:45 |
Pol | Oki | 18:21:53 |
Jan Tojnar | when invalid value is passed | 18:21:54 |
Jan Tojnar | which will be a head scratcher | 18:22:12 |
Pol | Removed | 18:22:17 |
Jan Tojnar | removing it will make it fail loudly by cp failing | 18:22:32 |
Pol | I see. Fair enough :) | 18:23:08 |
Pol | Job done. | 18:23:10 |
Pol | I'm still wondering if what I'm doing there is a good idea or not. | 18:23:24 |
Pol | Given all the issue we might face with Composer not being to reproduce correctly the outputs (poke tgerbet), I'm still wondering... | 18:23:57 |
Jan Tojnar | if you only do the download in FOD, it might be fine | 18:24:43 |
Jan Tojnar | you definitely cannot install there | 18:25:01 |
Pol | Can you tell me how am I supposed to do that? | 18:26:06 |
Pol | I have to use --download-only, right ? | 18:26:19 |
Pol | Ooooh I got it !!!! | 18:26:41 |
Pol | We do the download in the FOD | 18:26:49 |
Pol | Then the install in the outer derivation | 18:26:56 |
Pol | Oh that's clever damn. | 18:27:05 |
Jan Tojnar | yup | 18:28:32 |
Jan Tojnar | Pol: also with download-only most of the other flags are not relevant | 18:32:38 |
Jan Tojnar | and we probably do not want quit to make debugging easier | 18:32:55 |
Jan Tojnar | * and we probably do not want quiet to make debugging easier | 18:33:01 |
Pol | Oki | 18:33:10 |