In reply to @drupol:matrix.org
tgerbet, @Shyim ^^

Yeah this is not something really new, this is fine for personal/corporate stuff but not so much for nixpkgs:

• that cannot work with dependencies only using a source repository because that make us dependent on the output of git/svn/mercurial/whatever
• AFAIK there is no way to tell composer to use only dist tarball, there is a --prefer-dist flag but it will happily switch

In reply to @jtojnar:matrix.org
oh, right source deps are a thing. Maybe we could post-process the output to strip the VCS directories

In reply to @jtojnar:matrix.org
oh, right source deps are a thing. Maybe we could post-process the output to strip the VCS directories

Here's what I succeeded to do in 30 minutes:

{ buildPHPproject, fetchFromGitHub, makeWrapper, lib, php, tree }:

buildPHPproject rec {
  inherit php;

  pname = "grumphp";
  version = "1.15.0";

  src = fetchFromGitHub {
    owner = "phpro";
    repo = "grumphp";
    rev = "v${version}";
    hash = "sha256-EIGIoImRKR1Mc7oFXIzuLD3S1zx9WtHwDX0ST1T4BH0=";
  };

  vendorOutputHash = "sha256-TGGwRh7NSBKqt43GpmS7zY6togyEkEk/6wf2ys18OF8=";

  postInstall = ''
     ln -s $out/share/php/${pname}/bin/${pname} $out/bin/${pname}
  '';
}

Here's what I succeeded to do in 30 min, with the grumphp derivation as example:

{ buildPHPproject, fetchFromGitHub, makeWrapper, lib, php, tree }:

buildPHPproject rec {
  inherit php;

  pname = "grumphp";
  version = "1.15.0";

  src = fetchFromGitHub {
    owner = "phpro";
    repo = "grumphp";
    rev = "v${version}";
    hash = "sha256-EIGIoImRKR1Mc7oFXIzuLD3S1zx9WtHwDX0ST1T4BH0=";
  };

  vendorOutputHash = "sha256-TGGwRh7NSBKqt43GpmS7zY6togyEkEk/6wf2ys18OF8=";

  postInstall = ''
     ln -s $out/share/php/${pname}/bin/${pname} $out/bin/${pname}
  '';
}

Here's what I succeeded to do in 30 min, with the grumphp derivation as example:

{ buildPHPproject, fetchFromGitHub, lib, php }:

buildPHPproject rec {
  inherit php;

  pname = "grumphp";
  version = "1.15.0";

  src = fetchFromGitHub {
    owner = "phpro";
    repo = "grumphp";
    rev = "v${version}";
    hash = "sha256-EIGIoImRKR1Mc7oFXIzuLD3S1zx9WtHwDX0ST1T4BH0=";
  };

  vendorOutputHash = "sha256-TGGwRh7NSBKqt43GpmS7zY6togyEkEk/6wf2ys18OF8=";

  postInstall = ''
     ln -s $out/share/php/${pname}/bin/${pname} $out/bin/${pname}
  '';
}

Here's what I succeeded to do in 30 min, with the grumphp derivation as example:

{ buildPHPproject, fetchFromGitHub, lib }:

buildPHPproject rec {
  pname = "grumphp";
  version = "1.15.0";

  src = fetchFromGitHub {
    owner = "phpro";
    repo = "grumphp";
    rev = "v${version}";
    hash = "sha256-EIGIoImRKR1Mc7oFXIzuLD3S1zx9WtHwDX0ST1T4BH0=";
  };

  vendorOutputHash = "sha256-TGGwRh7NSBKqt43GpmS7zY6togyEkEk/6wf2ys18OF8=";

  postInstall = ''
     cd $out
     ln -s $out/share/php/${pname}/bin/${pname} $out/bin/${pname}
  '';

  meta = with lib; {
    changelog = "https://github.com/phpro/grumphp/releases/tag/v${version}";
    description = "A PHP code-quality tool";
    homepage = "https://github.com/phpro/grumphp";
    license = licenses.mit;
    maintainers = teams.php.members;
  };
}