| 17 Feb 2023 |
 Pol | I have the feeling that the patch that you did to remove the failing tests for opcache needs to be amended and some conditions based on the PHP versions added. | 07:20:18 |
| Pol | Apparently, those tests doesn't exists in PHP < 7.2 | 07:20:29 |
| Pol | Jan Tojnar: Any clue why this wasn't caught in fossar/nix-phps ? | 07:21:06 |
| Pol | Actually it wasn't caught in fossar/nix-phps because it's not building for Apple. | 07:44:43 |
| Pol | 
Download image.png | 07:47:02 |
| Pol | I'm thinking about something like:
| 07:47:03 |
| Pol | * I'm thinking about something like ^^ | 07:47:08 |
| Pol | Maybe I'll do it in fossar/nix-phps, that's actually the most appropriate place since we're not maintaining older version of PHP in nixpkgs. | 07:51:35 |
| Pol | PR: https://github.com/fossar/nix-phps/pull/212 | 08:04:13 |
| Pol | tgerbet, Jan Tojnar : Are you ok with this? ^^ | 08:12:59 |
 tgerbet | I think your commit message should say >= 7.2 😅 | 08:38:02 |
| Pol | oh ... let me check. | 08:40:29 |
| tgerbet | Do you see failures for PHP 7.x ? Maybe you could be stricter and only apply it on >= 8.0 ? | 08:41:09 |
| Pol | Redacted or Malformed Event | 08:43:41 |
| Pol | Redacted or Malformed Event | 08:44:29 |
| Pol | Redacted or Malformed Event | 08:44:44 |
| Pol | In reply to @tgerbet:matrix.org
Do you see failures for PHP 7.x ? Maybe you could be stricter and only apply it on >= 8.0 ? I mean, there is failure only for PHP 5.6, 7.0, 7.1. | 08:46:11 |
| Pol | In reply to @tgerbet:matrix.org
Do you see failures for PHP 7.x ? Maybe you could be stricter and only apply it on >= 8.0 ? * There are failure only for PHP 5.6, 7.0, 7.1. | 08:46:19 |
| tgerbet | Yes but the removal of the test files might not be needed in the range [7.2-7.4] if the tests are not flaky for some reasons | 08:47:37 |
| tgerbet | I have no clue if that's the case or not TBH | 08:48:59 |
| Pol | It's now green with that PR: https://github.com/loophp/nix-shell/pull/131 | 08:59:00 |
| 20 Feb 2023 |
| Pol | Someone submitted a PR to have PHPUnit in Nix at https://github.com/NixOS/nixpkgs/pull/217207 | 09:49:09 |
 @etu:failar.nu | I think that for phpunit it may matter which version of PHP you run it with | 09:55:38 |
| @etu:failar.nu | And then it should be below php-packages so you can select version | 09:55:53 |
| Pol | I don't think the same, maybe we should discuss that in the thread then? WDYT ? | 10:03:57 |
| Pol | I think we shouldn't take care of the PHP version here and always use the latest. | 10:04:15 |
| Pol | In reply to @etu:failar.nu
I think that for phpunit it may matter which version of PHP you run it with I could also ask Sebastian (phpunit's father) about that. We could also check how they do in other distro? | 10:06:46 |
| @etu:failar.nu | I think most people install it with composer | 10:19:07 |
| @etu:failar.nu | Then you have all the right things in place | 10:19:15 |
| @etu:failar.nu | I'm pretty confident that phpunit evaluates PHP with the version of PHP as you run PHP unit with. | 10:19:54 |
