| 15 Feb 2023 |
Pol | Apparently there was an issue with release 8.1.16 (dixit ramsey on Mastodon). Those issues are solved now, but we need to wait for the cache to update. However, issues on 8.0 and 8.2 are kinda unexpected. | 07:42:51 |
Pol | tgerbetetu builds are passing now at https://github.com/NixOS/nixpkgs/pull/216348 | 21:44:51 |
Pol | I guess it was related to the openssl updates this week. | 21:45:02 |
| 16 Feb 2023 |
@etu:failar.nu | Woop woop | 08:44:14 |
@etu:failar.nu | PHP updates merged on both master and backport 🙂 | 08:44:39 |
tgerbet | My nixpkgs-reviewis still running on the backport 😅 | 08:52:28 |
@etu:failar.nu | Yeah, I waited for the evals to finish on all architectures, no detected failures there | 08:58:47 |
@etu:failar.nu | A nixpkgs-review is also good since that's more extensive :) | 08:59:00 |
tgerbet | Yup looks good so far, I will let it go through "just in case" | 09:00:15 |
| 17 Feb 2023 |
Pol | tgerbet, Jan Tojnar : https://github.com/loophp/nix-shell/actions/runs/4200834200/jobs/7287266267 | 07:19:47 |
Pol | I have the feeling that the patch that you did to remove the failing tests for opcache needs to be amended and some conditions based on the PHP versions added. | 07:20:18 |
Pol | Apparently, those tests doesn't exists in PHP < 7.2 | 07:20:29 |
Pol | Jan Tojnar: Any clue why this wasn't caught in fossar/nix-phps ? | 07:21:06 |
Pol | Actually it wasn't caught in fossar/nix-phps because it's not building for Apple. | 07:44:43 |
Pol |  Download image.png | 07:47:02 |
Pol | I'm thinking about something like:
| 07:47:03 |
Pol | * I'm thinking about something like ^^ | 07:47:08 |
Pol | Maybe I'll do it in fossar/nix-phps, that's actually the most appropriate place since we're not maintaining older version of PHP in nixpkgs. | 07:51:35 |
Pol | PR: https://github.com/fossar/nix-phps/pull/212 | 08:04:13 |
Pol | tgerbet, Jan Tojnar : Are you ok with this? ^^ | 08:12:59 |
tgerbet | I think your commit message should say >= 7.2 😅 | 08:38:02 |
Pol | oh ... let me check. | 08:40:29 |
tgerbet | Do you see failures for PHP 7.x ? Maybe you could be stricter and only apply it on >= 8.0 ? | 08:41:09 |
Pol | Redacted or Malformed Event | 08:43:41 |
Pol | Redacted or Malformed Event | 08:44:29 |
Pol | Redacted or Malformed Event | 08:44:44 |
Pol | In reply to @tgerbet:matrix.org Do you see failures for PHP 7.x ? Maybe you could be stricter and only apply it on >= 8.0 ? I mean, there is failure only for PHP 5.6, 7.0, 7.1. | 08:46:11 |
Pol | In reply to @tgerbet:matrix.org Do you see failures for PHP 7.x ? Maybe you could be stricter and only apply it on >= 8.0 ? * There are failure only for PHP 5.6, 7.0, 7.1. | 08:46:19 |
tgerbet | Yes but the removal of the test files might not be needed in the range [7.2-7.4] if the tests are not flaky for some reasons | 08:47:37 |
tgerbet | I have no clue if that's the case or not TBH | 08:48:59 |