| 29 Dec 2022 |
 Pol | I'm discussing with @mic92 in the meantime. I think this PR should not be merged anymore. | 11:30:13 |
| Pol | 
Download image.png | 11:30:49 |
| Pol | Issue fixed: https://github.com/Mic92/nix-update/pull/123 | 13:08:34 |
| Pol | tgerbet: Issue is fixed in nix-update, @mic92 will commit the change as soon as the PHP PR is merged ! | 13:13:16 |
| Pol | tgerbet: I updated the PR accordingly, I simplified things as well, I guess it's much better. Let me know what you think. | 16:42:47 |
| Pol | tgerbet: I found a better solution again... | 17:24:24 |
| Pol | Sorry for the back and forth. | 17:25:47 |
| Pol | I stop touching it now :) | 17:25:51 |
| Pol | It's ready for me :) | 17:25:57 |
 tgerbet | In reply to @drupol:matrix.org
Sorry for the back and forth. It's fine, I just wish GitHub had a the possibility to see changes between two reviews like Gerrit 😅 | 17:28:25 |
| tgerbet | In reply to @drupol:matrix.org
Sorry for the back and forth. * It's fine, I just wish GitHub had the possibility to see changes between two reviews like Gerrit 😅 | 17:28:40 |
| Pol | Me too | 17:28:58 |
| Pol | Basicaly, I made the most changes in it: build-pecl.nix and php-packages.nix | 17:29:58 |
| Pol | Merci ! | 18:37:32 |
| 31 Dec 2022 |
| Pol | Jan Tojnar: I have been working on https://github.com/NixOS/nixpkgs/pull/180827 but I'm unable to trigger the update script.
I tried with nix-update -u php81 but I end up with error (see in the PR). I guess this is not the proper way to trigger it?
On the other hand, I updated the script (without being able to test it) as such, what do you think?
updateScript = writeShellScript "update.sh" ''
PATH=${lib.makeBinPath [ nix-update curl jq ]}
new_version=$(curl --silent "https://www.php.net/releases/active" | jq --raw-output '."${lib.versions.major version}"."${lib.versions.majorMinor version}".version')
nix-update --override-filename ./${lib.versions.majorMinor version}.nix --version "$new_version" php${lib.versions.major version}${lib.versions.minor version}
'';
| 14:21:18 |
| Pol | * Jan Tojnar: I have been working on https://github.com/NixOS/nixpkgs/pull/180827 but I'm unable to trigger the update script.
I tried with nix-update -u php81 but I end up with error (see in the PR). I guess this is not the proper way to trigger it?
On the other hand, I updated the script (without being able to test it) as such, what do you think?
updateScript = writeShellScript "update.sh" ''
PATH=${lib.makeBinPath [ nix-update curl jq ]}
new_version=$(curl --silent "https://www.php.net/releases/active" | jq --raw-output '."${lib.versions.major version}"."${lib.versions.majorMinor version}".version')
nix-update --override-filename ./${lib.versions.majorMinor version}.nix --version "$new_version" php${lib.versions.major version}${lib.versions.minor version}
'';
| 14:21:44 |
| 1 Jan 2023 |
| Pol | Happy new year all 🎊 ! | 01:04:30 |
| 3 Jan 2023 |
| Pol | There's this PR which is awaiting for love: https://github.com/NixOS/nixpkgs/pull/207088 | 20:27:50 |
| 4 Jan 2023 |
| Pol | This PR needs some love: https://github.com/NixOS/nixpkgs/pull/180827 | 10:23:47 |
| Pol | etu: WDYT about that ? ^^ | 12:36:52 |
 etu | I'll have a look at it later :) | 15:00:18 |
| etu | Pol: I'm not sure how to build it though:
error: syntax error, unexpected '/', expecting ID or OR_KW or DOLLAR_CURLY or '"', at /home/etu/code/nixpkgs/pkgs/development/interpreters/php/generic.nix:318:18
when doing nix-build -A php.updateScript
| 16:53:43 |
| Pol | Check the Github PR, the command to run to update it written there | 17:06:30 |
| Pol | The command is: nix-shell maintainers/scripts/update.nix --argstr commit true --argstr path php | 17:08:43 |
| etu | Same error | 17:14:48 |
| Pol | it's working here :S | 20:39:36 |
| Pol | 
Download image.png | 20:44:23 |
| Pol | (here it cannot find any release because 8.1.14 hasn't been yet announced officially) | 20:44:37 |
| Pol | But if you manually downgrade to 8.1.12, then re-run the command, it works. | 20:44:58 |
| 5 Jan 2023 |
| etu | Well, for me it doesn't eval at all | 06:26:46 |
