!jngDrdMgndWibPCYsR:nixos.org

Nix PHP

80 Members
A room for PHP developers running on Nix23 Servers

Load older messages

SenderMessageTime
27 Dec 2022
@drupol:matrix.orgPol * etu, aanderse, talyz ? ^^ 13:38:38
@drupol:matrix.orgPol I just updated the PR https://github.com/NixOS/nixpkgs/pull/207605 based on Jan Tojnar's feedback. It's ready for another round of review ! 21:35:20
28 Dec 2022
@tgerbet:matrix.orgtgerbetI made a few comments, mainly to fix the build and to have version numbers consistent with the rest of nixpkgs.20:16:57
@tgerbet:matrix.orgtgerbet * I made a few comments, mainly to fix the build of the gnupg extension and to have version numbers consistent with the rest of nixpkgs.20:19:22
@phaer:matrix.orgphaer joined the room.21:11:03
29 Dec 2022
@drupol:matrix.orgPol tgerbet: I was wondering how you found out that thing with gnupg ! In the meantime, I fixed all the suggestions. It's ready for another round of reviews. 08:42:22
@tgerbet:matrix.orgtgerbet I saw the submodule in the repo while checking the new source URLs so it was not too hard to find once the failures with nixpkgs-review 10:34:43
@drupol:matrix.orgPolNice :)10:35:04
@drupol:matrix.orgPolSubmodules is the only thing I try to avoid using in Git... so I never think about that.10:35:24
@tgerbet:matrix.orgtgerbetI'm doing some tests with the PR, if everything looks fine I will merge it. It touches a lot of things so it will be painful/annoying if it stays open for too long and there is not a lot of risks.10:42:46
@drupol:matrix.orgPolYep indeed.11:02:18
@drupol:matrix.orgPol The idea here is to make sure we can upgrade packages and extension by using something likenix-update -u --commit php.packages.grumphp ! 11:04:01
@drupol:matrix.orgPolThat said11:06:27
@drupol:matrix.orgPol I think there is an issue with nix-update. 11:06:37
@drupol:matrix.orgPolIf you can confirm... 11:06:42
@drupol:matrix.orgPol
  1. cd nixpkgs
    git checkout master
11:06:58
@drupol:matrix.orgPol *
  1. cd nixpkgs
  2. git checkout master
  3. git pull
  4. nix edit .#php.extensions.xdebug
  5. Replace the content of that derivation with the previous version:
{ buildPecl, lib, fetchFromGitHub, nix-update-script }:

let
  version = "3.1.0";
in buildPecl {
  inherit version;

  pname = "xdebug";

  src = fetchFromGitHub {
    owner = "xdebug";
    repo = "xdebug";
    rev = version;
    sha256 = "sha256-eT/N+mPhI1DyUKi+S770bWK09+CzmI1ZqnrxTXr5A2U=";
  };

  doCheck = true;
  checkTarget = "test";

  zendExtension = true;

  passthru = {
    updateScript = nix-update-script {};
  };

  meta = with lib; {
    changelog = "https://github.com/xdebug/xdebug/releases/tag/${version}";
    description = "Provides functions for function traces and profiling";
    license = licenses.php301;
    homepage = "https://xdebug.org/";
    maintainers = teams.php.members;
  };
}
11:08:54
@drupol:matrix.orgPol *
  1. cd nixpkgs
  2. git checkout master
  3. git pull
  4. nix edit .#php.extensions.xdebug
  5. Replace the content of that derivation with the previous version:
{ buildPecl, lib, fetchFromGitHub, nix-update-script }:

let
  version = "3.1.0";
in buildPecl {
  inherit version;

  pname = "xdebug";

  src = fetchFromGitHub {
    owner = "xdebug";
    repo = "xdebug";
    rev = version;
    sha256 = "sha256-eT/N+mPhI1DyUKi+S770bWK09+CzmI1ZqnrxTXr5A2U=";
  };

  doCheck = true;
  checkTarget = "test";

  zendExtension = true;

  passthru = {
    updateScript = nix-update-script {};
  };

  meta = with lib; {
    changelog = "https://github.com/xdebug/xdebug/releases/tag/${version}";
    description = "Provides functions for function traces and profiling";
    license = licenses.php301;
    homepage = "https://xdebug.org/";
    maintainers = teams.php.members;
  };
}
  1. Run nix-update --commit php.extensions.xdebug
11:09:33
@drupol:matrix.orgPolAs you can see, it doesn't get updated.11:09:54
@drupol:matrix.orgPol There is something going on since the last update of nix-update. I'm pretty sure this was working when I started to do the PR ! 11:10:16
@drupol:matrix.orgPol * As you can see, it doesn't get updated. The derivation should be updated to 3.2.0, but it doesn't.11:11:28
@drupol:matrix.orgPolimage.png
Download image.png		11:12:10
@drupol:matrix.orgPol We can see in the log: Update 3.1.0 -> 3.2.0 11:12:26
@drupol:matrix.orgPol Maybe Jan Tojnar has an idea since he made a review point asking me to remove the attrName from the commits at https://github.com/NixOS/nixpkgs/pull/207605#pullrequestreview-1230907654 11:17:59
@drupol:matrix.orgPol * Maybe Jan Tojnar has an idea since he made a review point asking me to remove the attrPath from the commits at https://github.com/NixOS/nixpkgs/pull/207605#pullrequestreview-1230907654 11:18:14
@drupol:matrix.orgPol * 🛑 I think there is an issue with nix-update. 11:20:24
@drupol:matrix.orgPol *
  1. cd nixpkgs
  2. git checkout master
  3. git pull
  4. open pkgs/development/php-packages/xdebug/default.nix
  5. Replace the content of that derivation with the previous version:
{ buildPecl, lib, fetchFromGitHub, nix-update-script }:

let
  version = "3.1.0";
in buildPecl {
  inherit version;

  pname = "xdebug";

  src = fetchFromGitHub {
    owner = "xdebug";
    repo = "xdebug";
    rev = version;
    sha256 = "sha256-eT/N+mPhI1DyUKi+S770bWK09+CzmI1ZqnrxTXr5A2U=";
  };

  doCheck = true;
  checkTarget = "test";

  zendExtension = true;

  passthru = {
    updateScript = nix-update-script {};
  };

  meta = with lib; {
    changelog = "https://github.com/xdebug/xdebug/releases/tag/${version}";
    description = "Provides functions for function traces and profiling";
    license = licenses.php301;
    homepage = "https://xdebug.org/";
    maintainers = teams.php.members;
  };
}
  1. Run nix-update --commit php.extensions.xdebug
11:23:22
@drupol:matrix.orgPolI'm discussing with @mic92 in the meantime. I think this PR should not be merged anymore.11:30:13
@drupol:matrix.orgPolimage.png
Download image.png		11:30:49
@drupol:matrix.orgPolIssue fixed: https://github.com/Mic92/nix-update/pull/12313:08:34

Show newer messages

Back to Room ListRoom Version: 6