| 13 Nov 2022 |
etu | I'm not sure if there's a policy that says something about this. | 10:56:44 |
Andreas Schrägle | In reply to @etu:failar.nu I'm not sure if there's a policy that says something about this. probably isn't. just wanted to ask. I don't have any strong opinion either way, tbh. | 11:01:44 |
etu | Pol: The PHP 8.2 PR misses an entry in: nixos/tests/all-tests.nix to have the tests for the right version | 11:35:42 |
Pol | oh. | 11:36:37 |
Pol | Trying. | 11:36:39 |
Pol | Done. | 11:37:42 |
etu | Pol: Do you mind rebasing the 8.2 on master, just to build it on NTS? | 12:34:23 |
etu | Minor fix: https://github.com/NixOS/nixpkgs/pull/201018 | 12:48:28 |
etu | That one would probably be required for ZHF as well :) | 12:48:48 |
Pol | Yes | 12:49:01 |
Pol | Approved | 13:07:16 |
Pol | And PHP 8.2 PR has been rebased | 13:07:25 |
Pol | etu: Should I add a release-note entry for php 8.2.0rc6 ? | 19:12:23 |
Pol | If yes, where? | 19:12:29 |
etu | In reply to @drupol:matrix.org If yes, where? Somewhere in the highways, I'll get back to you tomorrow if you want more specific than that :) | 19:23:04 |
etu | Btw, PHP NTS PR just hit NixOS unstable small ☺️ | 19:23:38 |
Pol | So happy about that :) | 19:23:58 |
Pol | In reply to @etu:failar.nu Somewhere in the highways, I'll get back to you tomorrow if you want more specific than that :) I just need the name of the file where to add the log, but yeah of course it can wait, no worries. | 19:24:38 |
etu | Same file and kinda same place as you put the release note for NTS | 19:25:39 |
Pol | Ok ! | 19:39:14 |
Pol | Job done. | 19:42:03 |
| 16 Nov 2022 |
Pol | I'm looking for help on this: | 17:55:47 |
Pol | https://github.com/NixOS/nixpkgs/pull/201000/checks?check_run_id=9531358635 | 17:55:48 |
Pol | > AssertionError: PHP version not detected | 17:56:00 |
Pol | I think I found a way to fix | 17:59:29 |
Pol | working on it. | 17:59:33 |
Pol | https://github.com/NixOS/nixpkgs/pull/201000 ! | 19:08:49 |
| @omlet:matrix.org joined the room. | 20:34:06 |
| 20 Nov 2022 |
Pol | etu: Branch off is Monday, is this PR ok for you now? ^^ | 10:29:07 |
| @omlet:matrix.org left the room. | 10:31:56 |