| 27 Oct 2022 |
Jan Tojnar | In reply to @drupol:matrix.org What would be the steps to do that on fossar/nix-phps ? I typically edit my nixpkgs checkout and then run nix build --override-input nixpkgs ~/Projects/nixpkgs ... in the nix-phps repo | 17:46:58 |
Jan Tojnar | looks like it would go to the main php derivation | 17:47:40 |
Pol | In reply to @jtojnar:matrix.org looks like it would go to the main php derivation In NixOS/nixpkgs or fossar/nix-phps ? | 18:19:53 |
Pol | Ok I think I got it working by hacking generic.nix. | 18:30:42 |
Pol | Going to submit the PR. | 18:30:49 |
Pol | https://github.com/NixOS/nixpkgs/pull/198111 | 18:33:52 |
Jan Tojnar | Pol: probably should go to nix-phps if it does not affect newer versions | 18:37:14 |
Jan Tojnar | also to buildInputs since it is a host platform dependency | 18:37:41 |
Pol | yes, but how to add a nativeBuildInputs in nix-phps, that was my first concern actually. I'm having trouble seeing how to do that. | 18:37:46 |
Jan Tojnar | put it to https://github.com/fossar/nix-phps/blob/0e230ec9bac6c7d2742285bb34fef1cdab5b9d57/pkgs/phps.nix#L23 | 18:38:29 |
Pol | Ok. | 18:40:30 |
Pol | Going to cancel the PR. | 18:40:33 |
Pol | In reply to @jtojnar:matrix.org also to buildInputs since it is a host platform dependency So, I add it in buildInputs instead of nativeBuildInputs ? | 18:41:49 |
Jan Tojnar | yup | 18:42:22 |
Pol | buildInputs = attrs.buildInputs ++ prev.lib.optionals (prev.lib.versionOlder args.version 7.1) [
prev.libxcrypt
];
| 18:43:08 |
Pol | Something like that? | 18:43:11 |
Jan Tojnar | quote the version number | 18:44:56 |
Jan Tojnar | otherwise lgtm | 18:45:04 |
Pol | https://github.com/fossar/nix-phps/pull/162 | 18:46:14 |
Pol | Green | 19:09:32 |
Pol | And php82 rc5: https://github.com/fossar/nix-phps/pull/163 | 19:34:36 |
| 28 Oct 2022 |
Andreas Schrägle | has anyone here seem more occurrences of stuff like https://github.com/NixOS/nixpkgs/issues/197726? | 00:04:07 |
Andreas Schrägle | meaning php software relying on ancient shitty not being available anymore (by default) when building php against openssl 3.xcrypto existing | 00:04:49 |
Andreas Schrägle | * meaning php software relying on ancient shitty not being available anymore (by default) when building php against openssl 3.x | 00:04:52 |
Andreas Schrägle | * meaning php software relying on ancient shitty crypto not being available anymore (by default) when building php against openssl 3.x | 00:06:36 |
Pol | I had similar issue in symfony when doing https requests, but they are treated as warnings. I will see if I can find it. | 05:47:51 |
Pol | Jan Tojnar: Homework: https://github.com/fossar/nix-phps/pull/163 | 05:47:59 |
Andreas Schrägle | https://www.php.net/ChangeLog-8.php#8.0.25 | 11:02:21 |
Andreas Schrägle | might open a PR later, but not sure if I'll have the time | 11:03:03 |
etu | They usually make a release for all the minor releases, so I'd wait a couple of hours and get both in at the same time :) | 11:41:34 |