| 3 Oct 2022 |
Pol | They definitely need to be addressed. | 05:50:04 |
Pol | PR for the first blocker: https://github.com/NixOS/nixpkgs/pull/194172 | 06:32:30 |
Pol | Feedback welcome ! | 06:32:35 |
etu | Pol: Feel free to rebase your php imap PR on master so we can get the full stack building on darwin 🙂 | 06:40:43 |
Pol | W000000t ! Will do that as soon as I step in my office... Commuting right now. | 06:42:52 |
Pol | Do you have any idea why this is breaking on darwin? https://logs.nix.ci/?key=nixos/nixpkgs.194172&attempt_id=712981f5-3861-4053-9e06-41520615ce97 | 07:11:09 |
Pol | > ld: library not found for -lldap
> clang-11: error: linker command failed with exit code 1 (use -v to see invocation)
> make: *** [Makefile:138: libs/libphp.bundle] Error 1
| 07:11:19 |
Pol | And I can see that openldap is correctly fetched and included | 07:11:35 |
Pol | (related PR: https://github.com/NixOS/nixpkgs/pull/194172) | 07:11:50 |
Pol | In reply to @etu:semi.social Pol: Feel free to rebase your php imap PR on master so we can get the full stack building on darwin 🙂 Looks like we have another issue now. | 07:59:45 |
etu | Indeed | 07:59:54 |
etu | Now it's about the actual PHP extension | 08:00:06 |
Pol | https://stackoverflow.com/questions/52314179/errors-when-installing-imap-extension-on-official-php-docker-image | 08:00:23 |
Pol | Going to add new flags. | 08:01:18 |
Pol | GREEN ! :) | 08:09:03 |
Pol | etu: Ready to be merged :D | 08:22:12 |
Pol | Oops no, it's not yet done. | 08:23:48 |
Pol | Weird it was showing that everything was done 1 minute ago. | 08:23:59 |
Pol | Now it's done. | 08:24:26 |
etu | Well, if it builds it builds | 08:25:04 |
etu | And it ran the tests as well so it should be fine :) | 08:25:13 |
Pol | massive! | 08:25:42 |
etu | So now we have figured out why imap were disabled for darwin 6 years ago and fixed it | 08:26:01 |
Pol | Yep, nice one | 08:26:14 |
etu | I'm pretty sure uwimap were possible to build on darwin back then as well... just that nobody cared enough 😛 | 08:26:24 |
Pol | Now the 22.11 blocker :D | 08:26:25 |
Pol | yep | 08:26:31 |
Pol | We should enable PHP nts by default instead of zts | 08:26:42 |
etu | I actually don't really know the difference :D | 14:04:17 |
Pol | It's about threads. NTS - Non Thread Safe, ZTS - Zend Thread Safe. | 14:16:12 |