| 20 May 2022 |
Pol | I have the feeling that it's something easy to do :) | 08:03:51 |
Jan Tojnar | In reply to @drupol:matrix.org Is this board related to PHP only? https://github.com/orgs/NixOS/projects/13 no, that is for whole NixOS project (you can see the description when you hover the title) | 09:55:05 |
Jan Tojnar | I suspect that someone just moved them from 22.05 blocker | 09:55:23 |
Pol | Ok ! I'm surprised that there's not a lot of blockers for the whole project :) | 09:55:27 |
Pol | Which is good ! | 09:55:33 |
Pol | And all the stuff there are a closely related to PHP | 09:55:44 |
Jan Tojnar | well, that is for the next-next release – people generally mark things as blockers for the upcoming release | 09:56:35 |
Pol | Ah right okay :) things will come in there soon then ! | 10:00:05 |
Andreas Schrägle | In reply to @jtojnar:matrix.org well, that is for the next-next release – people generally mark things as blockers for the upcoming release except for openssl 3, which someone (maybe me) added to release blockers for 23.05 | 13:14:37 |
| 22 May 2022 |
etu | In reply to @drupol:matrix.org I have the feeling that it's something easy to do :) Yeah, I usually do that in the spring after branch-off for the release that is about to be made :) | 08:38:41 |
Pol | Looking for review here: https://github.com/NixOS/nixpkgs/pull/173517 | 15:02:00 |
etu | In reply to @jtojnar:matrix.org I suspect that someone just moved them from 22.05 blocker Nah, I added them to 22.11 because it would be nice to have them done by then. They weren't in a milestone at all before. | 17:21:21 |
| 27 May 2022 |
Jan Tojnar | aanderse: did you ever get around to getting phpfpm to run as non-root? | 15:28:14 |
Andreas Schrägle | we have something for that. it sort of works, even. | 15:34:42 |
Andreas Schrägle | can probably leak you the module, later, if you want it. | 15:35:01 |
Jan Tojnar | would be helpful | 15:36:55 |
Jan Tojnar | currently, I am just chowning cache directory in ExecStartPost | 15:40:08 |
Jan Tojnar | but that does not work for '${CREDENTIALS_DIRECTORY} | 15:42:12 |
aanderse | Jan Tojnar: yes, i pushed a branch at one point but i didn't do enough testing in a production environment to feel comfortable with making a PR | 16:09:31 |
aanderse | also, i'm relieved to see you are still here
with your PR the other day i got a bit worried you were leaving 😱
i hope that isn't the case | 16:10:20 |
Jan Tojnar | aanderse: no, that was just to reduce the noise from stable | 16:42:54 |
Jan Tojnar | unfortunately, I cannot live without Nix any more | 16:43:38 |
aanderse | hahaha I'm so glad to hear | 16:49:58 |
| 28 May 2022 |
Pol | In reply to @jtojnar:matrix.org unfortunately, I cannot live without Nix any more We all have the same virus :D | 09:00:07 |
| 29 May 2022 |
Pol | In reply to @jtojnar:matrix.org there is no such rule in the Makefile fragments, maybe an implicit rule? https://github.com/php/php-src/blob/f590782b60a4da31487e00a3d0accfaf5d406b1d/ext/tokenizer/Makefile.frag#L1 https://github.com/php/php-src/blob/f590782b60a4da31487e00a3d0accfaf5d406b1d/Zend/Makefile.frag#L8 I dedicate a couple of hours today, grepping and searching in the PHP src, couldn't find anything relevant. Help is very welcome on this. | 20:06:47 |
Pol | These are the last lines of logs:
php-tokenizer> /build/source/ext/tokenizer/../../Zend/zend_language_scanner.l:3008: bad character: {
php-tokenizer> /build/source/ext/tokenizer/../../Zend/zend_language_scanner.l:3096: bad character: }
php-tokenizer> /build/source/ext/tokenizer/../../Zend/zend_language_scanner.l:3099: bad character: <
php-tokenizer> /build/source/ext/tokenizer/../../Zend/zend_language_scanner.l:3099: unknown error processing section 1
php-tokenizer> /build/source/ext/tokenizer/../../Zend/zend_language_scanner.l:3099: bad character: ,
php-tokenizer> /build/source/ext/tokenizer/../../Zend/zend_language_scanner.l:3099: unknown error processing section 1
php-tokenizer> /build/source/ext/tokenizer/../../Zend/zend_language_scanner.l:3099: bad character: >
php-tokenizer> /build/source/ext/tokenizer/../../Zend/zend_language_scanner.l:3099: bad character: {
php-tokenizer> /build/source/ext/tokenizer/../../Zend/zend_language_scanner.l:3099: unknown error processing section 1
php-tokenizer> /build/source/ext/tokenizer/../../Zend/zend_language_scanner.l:3099: bad character: }
php-tokenizer> /build/source/ext/tokenizer/../../Zend/zend_language_scanner.l:3099: bad character: {
php-tokenizer> /build/source/ext/tokenizer/../../Zend/zend_language_scanner.l:3105: bad character: }
php-tokenizer> /build/source/ext/tokenizer/../../Zend/zend_language_scanner.l:3107: bad character: *
php-tokenizer> /build/source/ext/tokenizer/../../Zend/zend_language_scanner.l:3107: bad character: /
php-tokenizer> /build/source/ext/tokenizer/../../Zend/zend_language_scanner.l:3151: bad character: }
php-tokenizer> /build/source/ext/tokenizer/../../Zend/zend_language_scanner.l:3152: premature EOF
php-tokenizer> make: *** [<builtin>: /build/source/ext/tokenizer/../../Zend/zend_language_scanner.c] Error 1
php-tokenizer> make: *** Waiting for unfinished jobs....
php-tokenizer> mkdir .libs
php-tokenizer> gcc -I. -I/build/source/ext/tokenizer -I/build/source/ext/tokenizer/include -I/build/source/ext/tokenizer/main -I/build/source/ext/tokenizer -I/nix/store/y4cvs6zp97b4p7qsx3gb3wli0ykpz59v-php-8.2.0.pre+date=20220529142406-dev/include/php -I/nix/store/y4cvs6zp97b4p7qsx3gb3wli0ykpz59v-php-8.2.0.pre+date=20220529142406-dev/include/php/main -I/nix/store/y4cvs6zp97b4p7qsx3gb3wli0ykpz59v-php-8.2.0.pre+date=20220529142406-dev/include/php/TSRM -I/nix/store/y4cvs6zp97b4p7qsx3gb3wli0ykpz59v-php-8.2.0.pre+date=20220529142406-dev/include/php/Zend -I/nix/store/y4cvs6zp97b4p7qsx3gb3wli0ykpz59v-php-8.2.0.pre+date=20220529142406-dev/include/php/ext -I/nix/store/y4cvs6zp97b4p7qsx3gb3wli0ykpz59v-php-8.2.0.pre+date=20220529142406-dev/include/php/ext/date/lib -DHAVE_CONFIG_H -g -O2 -DZEND_COMPILE_DL_EXT=1 -c /build/source/ext/tokenizer/tokenizer_data.c -MMD -MF tokenizer_data.dep -MT tokenizer_data.lo -fPIC -DPIC -o .libs/tokenizer_data.o
php-tokenizer> mv -f y.tab.c /build/source/ext/tokenizer/../../Zend/zend_language_parser.c
php-tokenizer> mv: cannot stat 'y.tab.c': No such file or directory
php-tokenizer> make: *** [<builtin>: /build/source/ext/tokenizer/../../Zend/zend_language_parser.c] Error 1
note: keeping build directory '/tmp/nix-build-php-tokenizer-8.2.0.pre+date=20220529142406.drv-0'
error: builder for '/nix/store/hm91r5ljwl0myycnwyjccxcr014r0isd-php-tokenizer-8.2.0.pre+date=20220529142406.drv' failed with exit code 2;
last 10 log lines:
> /build/source/ext/tokenizer/../../Zend/zend_language_scanner.l:3107: bad character: /
> /build/source/ext/tokenizer/../../Zend/zend_language_scanner.l:3151: bad character: }
> /build/source/ext/tokenizer/../../Zend/zend_language_scanner.l:3152: premature EOF
> make: *** [<builtin>: /build/source/ext/tokenizer/../../Zend/zend_language_scanner.c] Error 1
> make: *** Waiting for unfinished jobs....
> mkdir .libs
> gcc -I. -I/build/source/ext/tokenizer -I/build/source/ext/tokenizer/include -I/build/source/ext/tokenizer/main -I/build/source/ext/tokenizer -I/nix/store/y4cvs6zp97b4p7qsx3gb3wli0ykpz59v-php-8.2.0.pre+date=20220529142406-dev/include/php -I/nix/store/y4cvs6zp97b4p7qsx3gb3wli0ykpz59v-php-8.2.0.pre+date=20220529142406-dev/include/php/main -I/nix/store/y4cvs6zp97b4p7qsx3gb3wli0ykpz59v-php-8.2.0.pre+date=20220529142406-dev/include/php/TSRM -I/nix/store/y4cvs6zp97b4p7qsx3gb3wli0ykpz59v-php-8.2.0.pre+date=20220529142406-dev/include/php/Zend -I/nix/store/y4cvs6zp97b4p7qsx3gb3wli0ykpz59v-php-8.2.0.pre+date=20220529142406-dev/include/php/ext -I/nix/store/y4cvs6zp97b4p7qsx3gb3wli0ykpz59v-php-8.2.0.pre+date=20220529142406-dev/include/php/ext/date/lib -DHAVE_CONFIG_H -g -O2 -DZEND_COMPILE_DL_EXT=1 -c /build/source/ext/tokenizer/tokenizer_data.c -MMD -MF tokenizer_data.dep -MT tokenizer_data.lo -fPIC -DPIC -o .libs/tokenizer_data.o
> mv -f y.tab.c /build/source/ext/tokenizer/../../Zend/zend_language_parser.c
> mv: cannot stat 'y.tab.c': No such file or directory
> make: *** [<builtin>: /build/source/ext/tokenizer/../../Zend/zend_language_parser.c] Error 1
For full logs, run 'nix log /nix/store/hm91r5ljwl0myycnwyjccxcr014r0isd-php-tokenizer-8.2.0.pre+date=20220529142406.drv'.
| 20:18:14 |
Jan Tojnar | Pol: as mentioned before, this is most likely due to missing flags | 20:34:37 |
Pol | yes yes I understood, but I tried to search and grep the php-src, couldn't find anything relevant :( | 20:34:58 |
Jan Tojnar | if flex is anything like bison, it runs in compatibility mode by default | 20:35:07 |
Jan Tojnar | did you try grepping the Makefiles that were produced in the build tree? | 20:36:06 |