| 21 Mar 2022 |
 Pol | * (it does not includes php 7.4.29 as it seems that there won't be any release this month.) | 08:41:38 |
| 23 Mar 2022 |
| Pol | How about merging that PR please? ^^ | 08:03:01 |
| 25 Mar 2022 |
| Pol | We have issue to build PHP <= 7.2: https://github.com/fossar/nix-phps/runs/5691255326?check_suite_focus=true | 11:46:30 |
| Pol | Looks like it's an issue with:
> checking for jpeg_read_header in -ljpeg... no
> configure: error: Problem with libjpeg.(a|so). Please check config.log for more information.
| 11:46:58 |
| Pol | * We have issue to build PHP <= 7.3: https://github.com/fossar/nix-phps/runs/5691255326?check_suite_focus=true | 11:47:12 |
| Pol | Locally, I have another issue: | 12:51:40 |
| Pol | 
Download image.png | 12:51:42 |
| Pol | weird stuff. | 12:51:53 |
 Jan Tojnar | Pol: it just looks like libpng or zlib is no longer in the dependencies | 13:13:04 |
| Jan Tojnar | most likely, they were previously propagated but not any more | 13:13:22 |
| Pol | Oh. Where should I look and/or add them then? in fossar/phps or somewhere else? | 13:14:21 |
| Jan Tojnar | likely | 13:19:23 |
| Jan Tojnar | if the unpropagation is correct | 13:19:39 |
| Pol | https://github.com/NixOS/nixpkgs/blob/master/pkgs/top-level/php-packages.nix#L295 | 13:20:13 |
| Pol | Not in there? | 13:20:24 |
| Jan Tojnar | well, it looks like it is not needed for newer versions for some reason | 13:21:12 |
| Pol | right. Then we mneed to add it in fosar/phps. I tried to search a bit, but don't know where to add it. Do you have a suggestion ? | 13:22:11 |
| Pol | * right. Then we mneed to add it in fossar/phps. I tried to search a bit, but don't know where to add it. Do you have a suggestion ? | 13:22:18 |
| Jan Tojnar | general rule of thumb, if phpExtensions.gd uses functions from libpng, then it should be dependency of phpExtensions.gd | 13:22:51 |
| Jan Tojnar | package-overrides.nix corresponds to php-packages.nix in fossar/nix-phps | 13:23:53 |
| Jan Tojnar | * php-packages.nix in Nixpkgs corresponds to package-overrides.nix in fossar/nix-phps | 13:24:23 |
| Pol | So I add a new entry in there with gd | 13:24:41 |
| Pol | * So I add a new entry in there with gd, and add the missing deps. | 13:24:47 |
| Jan Tojnar | yeah | 13:24:51 |
| Jan Tojnar | but we should also check if removing the propagation from libgd was a right thing | 13:25:49 |
| Jan Tojnar | (if not, it should be reverted) | 13:26:07 |
| Pol | In reply to @jtojnar:matrix.org
but we should also check if removing the propagation from libgd was a right thing How do you do that ? | 13:26:38 |
| Jan Tojnar | sorry, forgot to post the most likely responsible commit: https://github.com/NixOS/nixpkgs/commit/e986a2e0c2162941e12c9a32485a67f651a6c0d2 | 13:26:59 |
| Pol | Wow | 13:28:59 |
| Jan Tojnar | Looking at ${gd.dev}/lib/pkgconfig/*.pc, those libraries are indeed listed in Requires.private field, not Requires. Nor does libpng seem to be mentioned in the headers. So it looks like a right call has been made. | 13:29:37 |
