| 2 May 2022 |
Pol | I think you just need to add: return Command::SUCCESS; and you're done. | 13:37:46 |
Pol | * I think you just need to add: return 0; and you're done. | 13:40:36 |
Pol | stephank (Stéphan Kochen): Let me know when you're available, I'd like to talk about this: https://github.com/stephank/composer-plugin-nixify/pull/3 | 20:56:40 |
| 3 May 2022 |
Pol | There's are PR to review here:
- https://github.com/NixOS/nixpkgs/pull/170614 (easy one)
- https://github.com/NixOS/nixpkgs/pull/170962
Any takes?
| 07:41:49 |
Pol | * There's are PR to review here:
- https://github.com/NixOS/nixpkgs/pull/170614 (easy one)
- https://github.com/NixOS/nixpkgs/pull/170962
Any takers?
| 07:41:51 |
Pol | * There's are PR to review here:
- https://github.com/NixOS/nixpkgs/pull/170614 (easy one)
- https://github.com/NixOS/nixpkgs/pull/170962
Anyone willing to take some?
| 07:44:40 |
Pol | https://phpc.social/@phpc/108239304489015508 ! => https://matrix.to/#/#phpcommunity:matrix.org | 18:08:24 |
ramsey | 🙂 | 18:16:53 |
Pol | I'm on it ! | 18:32:37 |
| joepferguson joined the room. | 19:06:33 |
| 4 May 2022 |
etu | Oh, this room is part of both the Nix space and PHP community space | 07:34:30 |
etu | That's cool :) | 07:34:32 |
Pol | yes :) | 07:40:20 |
Pol | etu: Is this one good enough as well?https://github.com/NixOS/nixpkgs/pull/170614 | 13:26:21 |
etu | In reply to @drupol:matrix.org etu: Is this one good enough as well?https://github.com/NixOS/nixpkgs/pull/170614 I found one thing interesting with that one, you link the homepage in the description, then you link the github page as the field homepage in the meta attribute 😉 | 13:28:10 |
Pol | Yeah it's intented. | 13:28:29 |
Pol | I prefer to link the github repo than a webpage | 13:28:39 |
Pol | Nothing escape your eyes :D | 13:28:56 |
etu | Many project websites are quite useless indeed | 13:29:08 |
etu | A github project is often more useful | 13:29:17 |
Pol | definitely | 13:29:21 |
etu | Ah, yes, you had the attribute name php74Packages.pdepend in the commit message as well, should be pdepend since it's not part of the phpPackages attribute | 13:30:44 |
Pol | omg. | 13:34:10 |
Pol | Fixing this now. | 13:34:13 |
Pol | Job done etu ! | 13:38:09 |
Pol | Thanks etu ! | 13:50:22 |
| @wybpip:matrix.org joined the room. | 15:03:11 |
| @wybpip:matrix.org left the room. | 15:03:12 |
| 7 May 2022 |
Jan Tojnar | anyone can review https://github.com/NixOS/nixpkgs/pull/170962? | 15:35:56 |
| 9 May 2022 |
Pol | PR to review:
- https://github.com/NixOS/nixpkgs/pull/170962 <- Needed to provide a PHP built from source.
| 12:32:45 |