| 8 Jan 2023 |
 etu | @Pol: Maybe we should consider to split out the php80 update to a separate PR to have it merged while waiting for some kind of response or take an action on php81 and php82? | 15:37:18 |
 Pol | I'm having limited availability to a computer these days, I might take 4~5 days before I do further changes on ths. | 16:06:21 |
| Pol | * I'm having limited availability to a computer these days, I might take 4~5 days before I do further changes on this. | 16:06:24 |
 tgerbet | If that's okay with you Pol I can take over to split the PHP 8.0 upgrade into an independent PR and start investigation the PHP 8.1/8.2 ext-opcache issue | 16:22:52 |
| tgerbet | * If that's okay with you Pol I can take over to split the PHP 8.0 upgrade into an independent PR and start investigating the PHP 8.1/8.2 ext-opcache issue | 16:26:01 |
| Pol | Merci <3 | 16:56:19 |
| tgerbet | The test fails because we have 2 additionnel warnings not present in the expectation 🤔 :
=====================================================================
FAILED TEST SUMMARY
---------------------------------------------------------------------
GH-9968: Preload crash on non-linked class [tests/gh9968.phpt]
=====================================================================
================================================================================
/build/php-8.2.1/ext/opcache/tests/gh9968.phpt
================================================================================
Warning: PHP Startup: Failed to open stream: No such file or directory in /build/php-8.2.1/ext/opcache/tests/gh9968-1.inc on line 3
Warning: PHP Startup: Failed opening 'ext/opcache/tests/gh9968-2.inc' for inclusion (include_path='.:/nix/store/bca038mr2v54v4y36lnq94qrji20bsp8-php-8.2.1/lib/php') in /build/php-8.2.1/ext/opcache/tests/gh9968-1.inc on line 3
Fatal error: Uncaught Error: Class "Root1_Constant_Referencer" not found in /build/php-8.2.1/ext/opcache/tests/gh9968.php:3
Stack trace:
#0 {main}
thrown in /build/php-8.2.1/ext/opcache/tests/gh9968.php on line 3
================================================================================
001+ Warning: PHP Startup: Failed to open stream: No such file or directory in /build/php-8.2.1/ext/opcache/tests/gh9968-1.inc on line 3
002+
003+ Warning: PHP Startup: Failed opening 'ext/opcache/tests/gh9968-2.inc' for inclusion (include_path='.:/nix/store/bca038mr2v54v4y36lnq94qrji20bsp8-php-8.2.1/lib/php') in /build/php-8.2.1/ext/opcache/tests/gh9968-1.inc on line 3
001- Warning: Can't preload unlinked class Root1_Constant_Referencer: Unknown parent Root2_Empty_Empty in %s on line %d
Fatal error: Uncaught Error: Class "Root1_Constant_Referencer" not found in %s:%d
Stack trace:
--
================================================================================
| 17:44:51 |
| tgerbet | * The test fails because we have 2 warnings that are not present in the expectation 🤔 :
=====================================================================
FAILED TEST SUMMARY
---------------------------------------------------------------------
GH-9968: Preload crash on non-linked class [tests/gh9968.phpt]
=====================================================================
================================================================================
/build/php-8.2.1/ext/opcache/tests/gh9968.phpt
================================================================================
Warning: PHP Startup: Failed to open stream: No such file or directory in /build/php-8.2.1/ext/opcache/tests/gh9968-1.inc on line 3
Warning: PHP Startup: Failed opening 'ext/opcache/tests/gh9968-2.inc' for inclusion (include_path='.:/nix/store/bca038mr2v54v4y36lnq94qrji20bsp8-php-8.2.1/lib/php') in /build/php-8.2.1/ext/opcache/tests/gh9968-1.inc on line 3
Fatal error: Uncaught Error: Class "Root1_Constant_Referencer" not found in /build/php-8.2.1/ext/opcache/tests/gh9968.php:3
Stack trace:
#0 {main}
thrown in /build/php-8.2.1/ext/opcache/tests/gh9968.php on line 3
================================================================================
001+ Warning: PHP Startup: Failed to open stream: No such file or directory in /build/php-8.2.1/ext/opcache/tests/gh9968-1.inc on line 3
002+
003+ Warning: PHP Startup: Failed opening 'ext/opcache/tests/gh9968-2.inc' for inclusion (include_path='.:/nix/store/bca038mr2v54v4y36lnq94qrji20bsp8-php-8.2.1/lib/php') in /build/php-8.2.1/ext/opcache/tests/gh9968-1.inc on line 3
001- Warning: Can't preload unlinked class Root1_Constant_Referencer: Unknown parent Root2_Empty_Empty in %s on line %d
Fatal error: Uncaught Error: Class "Root1_Constant_Referencer" not found in %s:%d
Stack trace:
--
================================================================================
| 17:46:29 |
| tgerbet | I have a fix, I'm doing some tests | 18:31:08 |
| tgerbet | PR updated, I'm running nixpkgs-review on it from a x86_64 systemd | 18:52:55 |
| tgerbet | * PR updated, I'm running nixpkgs-review on it from a x86_64 system | 18:52:57 |
| Pol | I saw the fix, nice !!! | 19:30:56 |
| 19 Jan 2023 |
|  @robert:funklause.de joined the room. | 18:20:24 |
| @robert:funklause.de left the room. | 18:22:06 |
| 20 Jan 2023 |
 phaer | Hello, I am running php-fpm on nginx on nixos 22.11 and even though error_log = syslog by default and i have catch_workers_output in my pool config, php errors do not seem to end up in php-fpms journal or anywhere else i can find them. | 12:36:54 |
| phaer | Is this expected behaviour? Shouldn't php errors be logged somewhere by default? Am i mssing a critical setting? | 12:37:23 |
 hexa | mayeb the app has a statedir, where it logs into var/log | 17:58:36 |
| hexa | I'm looking at you, wallabag | 17:58:44 |
| 21 Jan 2023 |
 philipp | And laravel and magento (shudder). | 15:28:05 |
| 23 Jan 2023 |
| Pol | Looking for comments in here: https://github.com/NixOS/nixpkgs/pull/212249#issuecomment-1400255969 | 12:22:06 |
| Pol | Especially from PHP Maintainers ^^ | 12:22:26 |
| etu | I also have the question if PHP version really matters when using that tool | 12:25:59 |
| etu | Like, does it make a difference to have 3 variants for it for each version? | 12:26:20 |
| etu | And the commit history needs... some work ;) | 12:26:34 |
| Pol | The commit history is the least of the issues and can be addressed at the end. I think here you're also making a good point and I would not include it in the php-packages namespace. | 12:34:49 |
| Pol | In the long run this is something I wish I could do in Nix... like remove phpstan, psalm, phpcsfixer from the php-packages namespace. | 12:35:25 |
| etu | Certain tools it makes sense to run with specific PHP versions | 12:58:11 |
| Pol | Yup, but not these | 12:59:40 |
| Pol | In reply to @drupol:matrix.org
Looking for comments in here: https://github.com/NixOS/nixpkgs/pull/212249#issuecomment-1400255969 He closed the PR... I think I got him frustrated | 13:00:15 |
| Pol | :( | 13:00:22 |
