Nix PHP | 76 Members | |
| A room for PHP developers running on Nix | 22 Servers |
| Sender | Message | Time |
|---|---|---|
| 6 Mar 2024 | ||
| Thank you ! | 08:05:24 | |
| Pol I was wondering a bit about the backport PR's. I think it's generally not done often to create backport for package updates, unless it's a security update or a situation where you can be 100% sure the update doesn't contain any backwards breaking changes. More info here I think it's virtually impossible (without auditing all the code) to guarentee that something doesn't contain a backward breaking change for for example phpunit or phpstan. Something somewhere only needs a simple typo fix (just a silly example) in an API and there is always someone somewhere that relies on it being with the typo. And relying on the blue eyes of upstream to not mess up semver is also not a good idea. (packages have semver violations constantly, and we don't have something like "automated" semver checks like in Rust where it helps a bit in that regard) | 11:49:48 | |
| Afk, brb | 11:53:08 | |
| I'm also unsure about the approach to take. Exemple in this PR: https://github.com/NixOS/nixpkgs/pull/293574, tgerbet told me to remove some commits. I'm also learning here. | 12:11:46 | |
| Maybe someone else in here can chime in with their experiences. I was planning to ask this in #dev:nixos.org as well, but later this week | 12:17:30 | |
| I would definitely be interested to know more about it as well. | 12:36:00 | |
| I tend to limit myself to stuff with security issues and/or annoying bugs when backporting mainly because it is extra work 😅. In this case I merged the PR because:
| 18:06:51 | |
| tgerbet: I hope you're OK when I ping you about PRs here | 18:26:03 | |
| Please, let me know if you think it's not appropriate. | 18:26:16 | |
| I don't want people to get bored/burntout/leaving because of me! | 18:26:33 | |
In reply to @drupol:matrix.orgBut you are Pol, this will not happen! :D | 18:26:51 | |
| I don't get it! | 18:27:12 | |
| * I don't get it! What do you mean ? | 18:27:25 | |
| I meant to say don't worry ^^ | 18:27:27 | |
| 9 Mar 2024 | ||
| 03:36:51 | ||
| 10 Mar 2024 | ||
| Jan Tojnar I have two questions you might be able to answer (other people too of course, if they know an answer).
| 18:42:50 | |
In reply to @patka_123:matrix.orgI think a package should only go to phpPackages when it changes behaviour based on PHP environment | 18:58:19 | |
top-level/aliases.nix is only for aliases in top-level, you will need to add the aliases to the phpPackages scope (similarly to how they are done in php extensions) | 18:59:30 | |
In reply to @jtojnar:matrix.orgSo then things like phpstan, codesniffer, php-cs-fixer, phpmd etc all belong outside of phpPackages? Or is that a wrong conclusion? | 19:01:34 | |
| it depends on how the tools are implemented | 19:02:31 | |
| for example, I know that php-parallel-linter does depend on PHP version | 19:03:02 | |
I'm not sure how to determine that, except for being familiar with the tool itself. Based on what did you determine that about php-parallel-linter for example? I guess something like php-cs-fixer then also changes behaviour based on environment, because it has different rules for different php versions? | 19:06:25 | |
| php-parallel-linter just calls php's built-in syntax checker IIRC | 19:07:52 | |
| I would expect phpstan and php-cs-fixer implementing everything themselves (IIRC they have target version config option that might default to the current version when not set but should result in the same output regardless the PHP version) | 19:09:53 | |
| though searching in memory now, I actually recall that PHPStan did have different results depending on PHP version | 19:11:03 | |
| Alright, that does make sense. Thanks for the explanation! I'm going to stay on the safe side, and leave this topic alone for now. I don't feel confident enough yet about making the decision that a package should go to by-name then | 19:13:00 | |
| New PHP PR for improving the PHP builder warning message in case of Composer validation failure: https://github.com/NixOS/nixpkgs/pull/294831 | 21:29:10 | |
| 12 Mar 2024 | ||
tgerbet: Are you ok with this? ^^ Eval is red, but that's because of the warning. How to deal with that in nixpkgs? | 09:36:31 | |
| 13 Mar 2024 | ||
| There is now a PHP label, so lets have them added automatically for us :) | 16:35:23 | |
| There is now a PHP label, so lets have them added automatically for us :) https://github.com/NixOS/nixpkgs/pull/295643 | 16:35:33 | |