| 1 Mar 2024 |
 @patka_123:matrix.org | Jesus, ****** christ. I am soooo blind... | 09:52:07 |
 @etu:failar.nu | In reply to @tgerbet:matrix.org
https://github.com/NixOS/nixpkgs/pull/292508 Oh, nice :) I've noticed this problem because I'm still using 8.1 :p | 10:07:15 |
 tgerbet | And fixing php81Packages.php-cs-fixer requires this patch and a patch like https://github.com/NixOS/nixpkgs/pull/292511
I will deal with it when it becomes possible
| 10:09:35 |
 Pol | @tgerbet can't test your PR but I can merge it if builds are passing | 11:08:14 |
 w | In reply to @tgerbet:matrix.org
Try with something looking like this
diff --git a/wordpress-configuration.nix b/wordpress-configuration.nix
index 04805bc..54eceb1 100644
--- a/wordpress-configuration.nix
+++ b/wordpress-configuration.nix
@@ -10,13 +10,13 @@
environment.systemPackages = with pkgs; [ wp4nix php ];
environment.variables.WP_VERSION = "6.4";
- nixpkgs.overlays = [ (self: super:
- wordpressPackages {
- src = builtins.fetchGit {
+ nixpkgs.overlays = [
+ (self: super: {
+ wordpressPackages = builtins.fetchGit {
url = "https://git.helsinki.tools/helsinki-systems/wp4nix";
ref = "master";
};
- }
- )];
+ })
+ ];
}
Worked, now goin for the new error msgs | 14:28:47 |
| w | Tks | 14:28:54 |
| w | Pol: once you asked me to try the new phpcomposer - but I lost track of the mesage. Could you send it to me again? | 14:31:06 |
| w | * Pol: once you asked me to try the new php composer - but I lost track of the mesage. Could you send it to me again? | 14:46:51 |
| Pol | Can't do that now on the phone. I'll be back tomorrow on my laptop . Ping me tomorrow and I'll see what I can do | 15:23:04 |
| 5 Mar 2024 |
| Pol | I just had a meeting with Seldaek (Jordi B, the Composer's father). | 11:47:19 |
| Pol | He gave me a better idea for the Composer builder. | 11:47:31 |
| Pol | That idea is great because:
- It simplifies the composer builder
- It works with ALL the versions of composer including >= 2.7
| 11:48:11 |
| Pol | Now I have to work on the composer plugin, make a new release, update the complete documentation... | 11:50:52 |
| Pol | So, composer 2.7.1 is not yet to be included in Nix this week. | 11:51:06 |
| Pol | You can follow the work here: https://github.com/NixOS/nixpkgs/pull/288574 | 11:51:19 |
| Pol | And here: https://github.com/nix-community/composer-local-repo-plugin/pull/6 | 11:51:39 |
| Pol | Suggestions, feedback are, as usual, more than welcome. | 11:51:51 |
| Pol | * Now I have to work on the composer plugin, make a new release, update the complete documentation, write tests,... | 11:52:52 |
| Pol | Ok I did it now. | 12:35:10 |
| Pol | https://github.com/NixOS/nixpkgs/pull/288574 | 12:35:11 |
| Pol | Ready for reviews | 12:35:16 |
| Pol | I added some contextual informations in the OP | 12:46:49 |
| Pol | tgerbet: Do you think you could review it at some point? | 12:53:39 |
| @patka_123:matrix.org | I just did and there is not much to review ^^ A very nice improvement! | 12:55:13 |
| Pol | :) Thanks | 12:55:53 |
| @patka_123:matrix.org | So now we'd only need to wait for a new composer release with your fix in it, right? | 12:56:45 |
| Pol | No | 12:57:41 |
| Pol | This updated version work for ALL the composer versions now. | 12:57:50 |
| Pol | I basically updated the Composer plugin we use internally. | 12:58:05 |
| Pol | => https://github.com/nix-community/composer-local-repo-plugin/pull/6 | 12:58:14 |
